Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added clear upgrade instructions to 4.0.4 docs #3333

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Added clear upgrade instructions to 4.0.4 docs #3333

merged 2 commits into from
Jul 17, 2020

Conversation

tangix
Copy link
Contributor

@tangix tangix commented Jul 16, 2020

Description
Fixing #3332

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan requested changes Jul 16, 2020
View reviewed changes
user_guide_src/source/installation/upgrade_404.rst Outdated

**Update FilterInterface declarations**

The method signatures for ``after()`` and ``before()`` need to be update to include ``$arguments``. The function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to be update to to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

MGatner
MGatner approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great to have. We’ll be better about posting these with releases.

@MGatner MGatner merged commit 871b845 into codeigniter4:develop Jul 17, 2020
@michalsn michalsn mentioned this pull request Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan requested changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangix @MGatner @paulbalandan