Merge pull request #3333 from tangix/add-upgrade-404

Added clear upgrade instructions to 4.0.4 docs
codeigniter4 · Jul 17, 2020 · 871b845 · 871b845
2 parents 2347772 + 96f7070
commit 871b845
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/user_guide_src/source/installation/upgrade_404.rst b/user_guide_src/source/installation/upgrade_404.rst
@@ -0,0 +1,20 @@
+#############################
+Upgrading from 4.0.x to 4.0.4
+#############################
+
+CodeIgniter 4.0.4 fixes a bug in the implementation of :doc:`Controller Filters </incoming/filters>`, breaking
+code implementing the ``FilterInterface``.
+
+**Update FilterInterface declarations**
+
+The method signatures for ``after()`` and ``before()`` must be updated to include ``$arguments``. The function
+definitions should be changed from::
+
+    public function before(RequestInterface $request)
+    public function after(RequestInterface $request, ResponseInterface $response)
+
+to::
+
+    public function before(RequestInterface $request, $arguments = null)
+    public function after(RequestInterface $request, ResponseInterface $response, $arguments = null)
+
diff --git a/user_guide_src/source/installation/upgrading.rst b/user_guide_src/source/installation/upgrading.rst
@@ -6,6 +6,7 @@ Please read the upgrade notes corresponding to the version you are
 upgrading from.
 
 .. toctree::
-	:titlesonly:
+    :titlesonly:
 
-	Upgrading from 3.x to 4.x <upgrade_4xx>
+    Upgrading from 4.0.x to 4.0.4 <upgrade_404>
+	Upgrading from 3.x to 4.x <upgrade_4xx>