Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clear upgrade instructions to 4.0.4 docs #3333

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Added clear upgrade instructions to 4.0.4 docs #3333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b187241
Added clear upgrade instructions to 4.0.4
tangix Jul 16, 2020
96f7070
Fixed spelling and added link to Controller Filters page.
tangix Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions user_guide_src/source/installation/upgrade_404.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#############################
Upgrading from 4.0.x to 4.0.4
#############################

CodeIgniter 4.0.4 fixes a bug in the implementation of Controller Filter, breaking
code implementing the ``FilterInterface``.

**Update FilterInterface declarations**

The method signatures for ``after()`` and ``before()`` need to be update to include ``$arguments``. The function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to be update to to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

definitions should be changed from::

public function before(RequestInterface $request)
public function after(RequestInterface $request, ResponseInterface $response)

to::

public function before(RequestInterface $request, $arguments = null)
public function after(RequestInterface $request, ResponseInterface $response, $arguments = null)
5 changes: 3 additions & 2 deletions user_guide_src/source/installation/upgrading.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Please read the upgrade notes corresponding to the version you are
upgrading from.

.. toctree::
:titlesonly:
:titlesonly:

Upgrading from 3.x to 4.x <upgrade_4xx>
Upgrading from 4.0.x to 4.0.4 <upgrade_404>
Upgrading from 3.x to 4.x <upgrade_4xx>