This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
upgrade @cockroachlabs/admin-ui-components version 0.1.37 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jan 19, 2021
58701: ui: statement details import r=koorosh a=koorosh Related to #57372 Depends on cockroachdb/ui#162 Depends on cockroachdb/yarn-vendored#51 Statement details and Diagnostics view pages are moved out to `admin-ui-components` package and now they are imported back as a reusable components. In addition to changed imports, StatementDetails component now exposes additional props for Diagnostics view tab. Before, StatementDetails component used Diagnostics view connected to store and now it uses pure component. This change were made to provide single point of integration to redux store (the same way as other components connected). Tracking analytics functionality for Diagnostics view was initially called directly from components and now it's refactored out of component and involved with redux actions and sagas. It was necessary to exclude this logic from pure components and allow client apps which integrate Statement details to implement their own logic for tracking analytics if necessary. TODO: - [x] remove all exported components from this code base to avoid duplicates. - [x] update `admin-ui-components` package version in `package.json` Release note: None Co-authored-by: Andrii Vorobiov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.