ui: statement details import #58701
Merged
ui: statement details import #58701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhartunian
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, 10 of 10 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
koorosh
force-pushed
the
ui-statement-details-import
branch
2 times, most recently
from
932dadf to
0eda739
Compare
|
Lint errors can be fixed with this change cockroachdb/ui#172 |
koorosh
force-pushed
the
ui-statement-details-import
branch
from
0eda739 to
e0d1b95
Compare
Statement details and Diagnostics view pages are moved out to `admin-ui-components` package and now they are imported back as a reusable components. In addition to changed imports, StatementDetails component now exposes additional props for Diagnostics view tab. Before, StatementDetails component used Diagnostics view connected to store and now it uses pure component. This change were made to provide single point of integration to redux store (the same way as other components connected). Release note: None
Currently, many components were exported to `admin-ui-components` package and these components weren't removed from this repo. To avoid duplicates, these components removed and re-imported back. Release note: None
koorosh
force-pushed
the
ui-statement-details-import
branch
from
e0d1b95 to
724cf52
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #57372
Depends on cockroachdb/ui#162
Depends on cockroachdb/yarn-vendored#51
Statement details and Diagnostics view pages are moved out
to
admin-ui-componentspackage and now they are imported backas a reusable components.
In addition to changed imports, StatementDetails component now exposes
additional props for Diagnostics view tab. Before, StatementDetails
component used Diagnostics view connected to store and now it uses
pure component. This change were made to provide single point of
integration to redux store (the same way as other components connected).
Tracking analytics functionality for Diagnostics view was initially called directly
from components and now it's refactored out of component and involved
with redux actions and sagas. It was necessary to exclude this logic from pure
components and allow client apps which integrate Statement details to implement
their own logic for tracking analytics if necessary.
TODO:
admin-ui-componentspackage version inpackage.jsonRelease note: None