Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Extract Statement Details Page from DB Console #57372

Closed
4 of 8 tasks
dhartunian opened this issue Dec 2, 2020 · 3 comments
Closed
4 of 8 tasks

ui: Extract Statement Details Page from DB Console #57372

dhartunian opened this issue Dec 2, 2020 · 3 comments
Assignees
@koorosh
Labels
A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear.

Comments

@dhartunian
Copy link
Collaborator

dhartunian commented Dec 2, 2020 •
edited by koorosh
Loading

See this doc for details https://docs.google.com/document/d/1POnd0peq25-unOEtQ8lwjPeJET6lHEYhJ49ZQEfx3TI/edit#heading=h.7qmr2zgyor18

  • Isolate CSS for Statement Details Page into modules
  • Move Statement Details Page component into admin-ui-component repo
  • Reimport Statement Details Page into DB Console
  • Clean up unused components and styles in DB Console after Statement Details Page import
  • Write new redux layer in admin-ui-components
    • nodes reducer and actions
  • Integrate Statement Details Page into CockroachCloud
  • Decouple analytics actions from component level.
@blathers-crl
Copy link

blathers-crl bot commented Dec 2, 2020

Hi @dhartunian, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@dhartunian dhartunian added the A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. label Dec 2, 2020
@exalate-issue-sync exalate-issue-sync bot mentioned this issue Dec 7, 2020
Closed
@exalate-issue-sync
Copy link

Assigned to Andrii Vorobyov

1 similar comment
@exalate-issue-sync
Copy link

Assigned to Andrii Vorobyov

This was referenced Jan 11, 2021
Merged
Merged
craig bot pushed a commit that referenced this issue Jan 19, 2021
@koorosh
Merge #58701
d84e680 
58701: ui: statement details import r=koorosh a=koorosh

Related to #57372
Depends on cockroachdb/ui#162
Depends on cockroachdb/yarn-vendored#51

Statement details and Diagnostics view pages are moved out
to `admin-ui-components` package and now they are imported back
as a reusable components.

In addition to changed imports, StatementDetails component now exposes
additional props for Diagnostics view tab. Before, StatementDetails
component used Diagnostics view connected to store and now it uses
pure component. This change were made to provide single point of
integration to redux store (the same way as other components connected).

Tracking analytics functionality for Diagnostics view was initially called directly
from components and now it's refactored out of component and involved
with redux actions and sagas. It was necessary to exclude this logic from pure
components and allow client apps which integrate Statement details to implement
their own logic for tracking analytics if necessary.

TODO:
- [x]  remove all exported components from this code base to avoid duplicates.
- [x]  update `admin-ui-components` package version in `package.json`

Release note: None

Co-authored-by: Andrii Vorobiov <[email protected]>
@nkodali nkodali closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koorosh koorosh

Labels
A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kenliu @jlinder @dhartunian @nkodali @koorosh