Translate paths in compilepkg output. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari-crl
force-pushed
the
pathtranslation
branch
from
4ba7ff8 to
fb8027f
Compare
rickystewart
approved these changes
Apr 7, 2022
|
As far as I can tell from my testing, trimpath has nothing to do with
_compilation_ error messages, only with _runtime_ error messages.
cockroachdb/cockroach#76377 (comment)
You can tell because if trimpath affected compilation error messages, it
would _already_ look like the third code block. It doesn't, though, it
looks like the second one.
…On Thu, Apr 7, 2022 at 5:04 PM Ricky Stewart ***@***.***> wrote:
***@***.**** approved this pull request.
This looks fine but I'm interested in why tweaking the -trimpath argument
in the compiler invocation is not what we're doing, primarily because that
would be less code. Does that not work for some reason?
—
Reply to this email directly, view it on GitHub
<#5 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYMCHUKSXJNLCV35VOCNT5TVD5EWDANCNFSM5SQ3MRRA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Mari* *Lyndon* *(**MAH-ree **LIN-dun) *🏳️⚧️ 🚺 *she/her*
👷🏻♀️ 🧰 Engineering Productivity
👩🏻💻 🪳 Software Engineer @ Cockroach Labs
🏡 🇺🇸 Richmond, VA (Eastern Time)
|
When cgo2 is involved in a build, the go srcs are linked/copied into a temporary directory to keep everything in the same directory. Those paths are unrecognizable to IDEs, being absolute paths outside the project directory. This adds a translation step to replace paths in the compiler output, translating them back to the input paths that were given to the tool in the first place. This doesn't affect -trimpath, which affects runtime error messages but not compilation-time error messages; for the same reason, this change can't use that flag to do its dirty work. Fixes cockroachdb/cockroach#76377. Release note: None
mari-crl
force-pushed
the
pathtranslation
branch
from
fb8027f to
2a778e9
Compare
|
Okay, updated comments (pull request, commit, and the one from the issue itself). Merging now! |
mari-crl
added a commit
to mari-crl/cockroach
that referenced
this pull request
Apr 8, 2022
The rules_go version has been bumped to accept the new changes from cockroachdb/rules_go#5. Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Apr 8, 2022
79245: ci: build and publish cockroach-sql r=rickystewart a=rail This patch adds `cockroach-sql` as a separate artifact published to S3. The binary is not stripped (TBD). Fixes #75800 Release note: None 79651: test: fix bazel sqllite invocation r=cucaroach a=cucaroach Release note: None 79661: WORKSPACE: update rules_go version r=mari-crl a=mari-crl The rules_go version has been bumped to accept the new changes from cockroachdb/rules_go#5. Finishing blow for #76377. Release note: None Co-authored-by: Rail Aliiev <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Mari Staib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cgo2 is involved in a build, the go srcs are linked/copied
into a temporary directory to keep everything in the same
directory. Those paths are unrecognizable to IDEs, being absolute
paths outside the project directory.
This adds a translation step to replace paths in the compiler output,
translating them back to the input paths that were given to the tool
in the first place.
This doesn't affect -trimpath, which affects runtime error messages
but not compilation-time error messages; for the same reason, this
change can't use that flag to do its dirty work.
Fixes cockroachdb/cockroach#76377.
Release note: None