Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build and publish cockroach-sql alongside the other release artifacts #75800

Closed
knz opened this issue Feb 1, 2022 · 0 comments · Fixed by #79245
Closed

ci: build and publish cockroach-sql alongside the other release artifacts #75800

knz opened this issue Feb 1, 2022 · 0 comments · Fixed by #79245
Assignees
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-release Release Engineering & Automation Team

Comments

@knz
Copy link
Contributor

knz commented Feb 1, 2022

We'd like to ship the small(er) cockroach-sql binary to our end-users.
For this it needs to be downloadable from our release buckets.
For this it needs to be built in CI.

So the request here is to update the rules in CI to build and publish the cockroach-sql binary (bazel build //pkg/cmd/cockroach-sql and strip cockroach-sql) alongside the other cockroach binary, for all the target platforms that we publish artifacts for.

Also it would be useful to run strip on the resulting binary, to reduce its size further. (but run strip just on cockroach-sql, not cockroach)

Jira issue: CRDB-12841

@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Feb 1, 2022
@exalate-issue-sync exalate-issue-sync bot added T-release Release Engineering & Automation Team and removed T-dev-inf labels Feb 9, 2022
@rail rail added T-release Release Engineering & Automation Team and removed T-release Release Engineering & Automation Team labels Feb 14, 2022
rail added a commit to rail/cockroach that referenced this issue Apr 1, 2022
This patch adds `cockroach-sql` as a separate artifact published to S3.
The binary is not stripped (TBD).

Fixes cockroachdb#75800

Release note: None
@craig craig bot closed this as completed in fb54ea7 Apr 8, 2022
blathers-crl bot pushed a commit that referenced this issue Apr 8, 2022
This patch adds `cockroach-sql` as a separate artifact published to S3.
The binary is not stripped (TBD).

Fixes #75800

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-release Release Engineering & Automation Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants