ci: build and publish cockroach-sql #79245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds `cockroach-sql` as a separate artifact published to S3. The binary is not stripped (TBD). Fixes cockroachdb#75800 Release note: None
rail
added
C-enhancement
|
This change is |
|
TBH, I'm not 100% happy with the implementation. I tried a few different approaches, but all of them require a lot of refactoring. I'd rather refactor the code as a separate task. Stripping is not enabled, because it feels like it should be done in Bazel. I'm not sure if we can strip individual files yet. |
rickystewart
approved these changes
Apr 8, 2022
|
bors r=rickystewart |
|
Build succeeded: |
|
blathers backport release-22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
cockroach-sqlas a separate artifact published to S3.The binary is not stripped (TBD).
Fixes #75800
Release note: None