Add missing t.Helper() #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed over in cockroachdb/cockroach that test failures were printed as originating from `datadriven.go:194` as opposed to the actual test's invocation of `datadriven.RunTest`. Inserting the missing `t.Helper()` call seems to have fixed that.
knz
approved these changes
Aug 26, 2020
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Aug 27, 2020
Picks up cockroachdb/datadriven#28. Release justification: testing Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Aug 27, 2020
53243: builtins: implement ST_IsPolygonCW/CCW and ST_ForcePolygonCW/CCW r=sumeerbhola a=otan Resolves #48956 Resolves #48957 Resolves #48935 Resolves #48936 Release note (sql change): implement the ST_IsPolygonCW, ST_IsPolygonCCW, ST_ForcePolygonCW and ST_ForcePolygonCCW builtins. Release justification: low risk, high benefit changes 53478: backupccl: prevent temporary tables from backupccl r=pbardea a=otan Filter out temporary tables from resolvable descriptors. Release justification: low risk, high benefit changes Resolves: #50902 Release note (sql change): Fix a bug where temporary tables may be included in `BACKUP` commands. 53496: builtins: implement ST_Points r=otan a=erikgrinaker Release note (sql change): Implement the geometry builtin `ST_Points`. Closes #49009. 53523: sql: allow INT to compare to OID r=jordanlewis a=rafiss An OID is just an INT, so they should be comparable. Postgres allows this, and certain drivers create queries that attempt to compare INTs to OIDs, so this improves compatibility. fixes #53143 Release justification: low-risk, high benefit change that improves compatibility with PGJDBC. Release note (sql change): A value of type OID can now be compared to a value of type INT. 53545: vendor: go get github.com/cockroachdb/datadriven@master r=knz a=tbg Picks up cockroachdb/datadriven#28. Release justification: testing Release note: None Co-authored-by: Oliver Tan <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed over in cockroachdb/cockroach that test failures were printed
as originating from
datadriven.go:194as opposed to the actual test'sinvocation of
datadriven.RunTest. Inserting the missingt.Helper()call seems to have fixed that.
This change is