builtins: implement ST_Points

[erikgrinaker]

Release note (sql change): Implement the geometry builtin ST_Points.

Closes #49009.

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

• @otan (author of geo/geomfn: implement ST_Points({geometry}) #49009)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[otan]

just a heads up -- i will probably have to get you to rebase this on top of #53446.

[otan]

you'll also need to add a Release justification at this stage in your commit message and PR description -- builtins fall under "low risk, high benefit" changes (this should appear automatically in your commit template when you rebase and amend commit)

We're in a period of stability right now, but the release branch has not been cut yet.

[erikgrinaker]

Sure, I'll update this once #53446 lands.

[otan]

It has landed!

[erikgrinaker]

Test failure seems unrelated:

[13:22:47]Run local roachtests (13m:45s)
[13:32:50][Run local roachtests] I200827 13:32:51.212715 21802 util/binfetcher/binfetcher.go:167  [w0] downloading https://binaries.cockroachdb.com/cockroach-v20.1.4.linux-amd64.tgz?ci=true to /go/src/github.com/cockroachdb/cockroach/artifacts/cockroach-v20.1.4.linux-amd64
[13:35:49][Run local roachtests] The service message is invalid because it does not end with ] character: ##teamcity[testFailed name='cdc/bank' details='test artifacts and logs in: artifacts/cdc/bank/run_1|n	cluster.go:2183,cdc.go:636,cdc.go:224,cdc.go:607,test_runner.go:754: output in run_133418.400_n4_for_i_in: /go/src/github.com/cockroachdb/cockroach/bin/roachprod run local:4 -- for i in $(seq 1 5); do curl --retry 3 --retry-delay 1 -o /tmp/confluent.tar.gz https://storage.googleapis.com/cockroach-fixtures/tools/confluent-oss-4.0.0-2.11.tar.gz && break |||| sleep 15; done && tar xvf /tmp/confluent.tar.gz -C /tmp/confluent returned: exit status 20|n		(1) attached stack trace|n		  -- stack trace:|n		  || main.(*cluster).RunE|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2261|n		  || main.(*cluster).Run|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2181|n		  || main.kafkaManager.install|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:636|n		  || main.runCDCBank|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:224|n		  || main.registerCDC.func8|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:607|n		  || main.(*testRunner).runTest.func2|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754|n		  || runtime.goexit|n		  || 	/usr/local/go/src/runtime/asm_amd64.s:1357|n		Wraps: (2) output in run_133418.400_n4_for_i_in|n		Wraps: (3) /go/src/github.com/cockroachdb/cockroach/bin/roachprod run local:4 -- for i in $(seq 1 5); do curl --retry 3 --retry-delay 1 -o /tmp/confluent.tar.gz https://storage.googleapis.com/cockroach-fixtures/tools/confluent-oss-4.0.0-2.11.tar.gz && break |||| sleep 15; done && tar xvf /tmp/confluent.tar.gz -C /tmp/confluent returned|n		  || stderr:|n		  || Speed   Time    Time     Time  Current|n		  ||                                  Dload  Upload   Total   Spent    Left  Speed|n		  || 
[13:35:49][Run local roachtests] The service message is invalid because it does not end with ] character: ##teamcity[testFailed name='cdc/bank' details='test artifacts and logs in: artifacts/cdc/bank/run_1|n	cluster.go:2183,cdc.go:636,cdc.go:224,cdc.go:607,test_runner.go:754: output in run_133418.400_n4_for_i_in: /go/src/github.com/cockroachdb/cockroach/bin/roachprod run local:4 -- for i in $(seq 1 5); do curl --retry 3 --retry-delay 1 -o /tmp/confluent.tar.gz https://storage.googleapis.com/cockroach-fixtures/tools/confluent-oss-4.0.0-2.11.tar.gz && break |||| sleep 15; done && tar xvf /tmp/confluent.tar.gz -C /tmp/confluent returned: exit status 20|n		(1) attached stack trace|n		  -- stack trace:|n		  || main.(*cluster).RunE|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2261|n		  || main.(*cluster).Run|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2181|n		  || main.kafkaManager.install|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:636|n		  || main.runCDCBank|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:224|n		  || main.registerCDC.func8|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:607|n		  || main.(*testRunner).runTest.func2|n		  || 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754|n		  || runtime.goexit|n		  || 	/usr/local/go/src/runtime/asm_amd64.s:1357|n		Wraps: (2) output in run_133418.400_n4_for_i_in|n		Wraps: (3) /go/src/github.com/cockroachdb/cockroach/bin/roachprod run local:4 -- for i in $(seq 1 5); do curl --retry 3 --retry-delay 1 -o /tmp/confluent.tar.gz https://storage.googleapis.com/cockroach-fixtures/tools/confluent-oss-4.0.0-2.11.tar.gz && break |||| sleep 15; done && tar xvf /tmp/confluent.tar.gz -C /tmp/confluent returned|n		  || stderr:|n		  || Speed   Time    Time     Time  Current|n		  ||                                  Dload  Upload   Total   Spent    Left  Speed|n		  || 
[13:36:30][Run local roachtests] Error: some tests failed
[13:36:30][Run local roachtests] Process exited with code 1

[otan]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)