Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: temporary tables should not be included in backup #50902

Closed
rohany opened this issue Jul 1, 2020 · 1 comment · Fixed by #53478
Closed

backupccl: temporary tables should not be included in backup #50902

rohany opened this issue Jul 1, 2020 · 1 comment · Fixed by #53478
Assignees
@otan
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@rohany
Copy link
Contributor

rohany commented Jul 1, 2020

The inclusion could cause problems upon restore, and it doesn't seem like other tools include these either.
@rohany rohany added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 1, 2020
@otan otan mentioned this issue Jul 9, 2020
Closed
@solongordon solongordon mentioned this issue Jul 9, 2020
Closed
@solongordon
Copy link
Contributor

Unclear if this is actually broken. Let's write a test and find out.

@solongordon solongordon assigned otan and unassigned arulajmani Aug 25, 2020
@otan otan mentioned this issue Aug 26, 2020
Merged
@craig craig bot closed this as completed in 1f1ac2e Aug 27, 2020
@pbardea pbardea mentioned this issue Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otan otan

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: prevent temporary tables from backupccl otan-cockroach/cockroach
4 participants
@solongordon @otan @arulajmani @rohany