txnwait: do not require vmodule to log deadlocks in a workload

[arulajmani]

Deadlocks in a workload are rare (and bad) enough that they should be logged at the level of Info, instead of under vmodule.

Epic: none

Release note: None

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[nvanbenschoten]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @arulajmani)

---

pkg/kv/kvserver/txnwait/queue.go line 722 at r1 (raw file):

				p1, p2 := pusheePriority, pusherPriority
				if p1 < p2 || (p1 == p2 && bytes.Compare(req.PusheeTxn.ID.GetBytes(), req.PusherTxn.ID.GetBytes()) < 0) {
					log.Infof(

Do you think we should wrap this in an EveryN? Maybe only log it once a second, and otherwise retain the log.VEventf? I think you can continue to use log.VEventf and then use level=0 for the analogous call to log.Infof, but please double-check if you decide to write this like that.

[nvanbenschoten]

This still seems like a good idea. I imagine we'll thank ourselves for adding in this logging at some point in the future.

[arulajmani]

Better late than never I guess 😅

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)

---

pkg/kv/kvserver/txnwait/queue.go line 722 at r1 (raw file):

I think you can continue to use log.VEventf and then use level=0 for the analogous call to log.Infof, but please double-check if you decide to write this like that.

You're correct; verified that this is indeed how it works.

[nvanbenschoten]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)

[arulajmani]

Thanks!

bors r=nvanbenschoten

[craig]

Build succeeded:

• acceptance
• lint
• unit_tests
• linux_amd64_fips_build
• linux_amd64_build
• macos_arm64_build
• docker_image_amd64
• local_roachtest
• local_roachtest_fips
• windows_build
• check_generated_code
• examples_orms
• macos_amd64_build
• linux_arm64_build