-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: txnwait: do not require vmodule to log deadlocks in a workload #126222
Conversation
Deadlocks in a workload are rare (and bad) enough that they should be logged at the level of Info, instead of under vmodule. Epic: none Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Reminder: it has been 3 weeks please merge or close your backport! |
Backport 1/1 commits from #99315 on behalf of @arulajmani.
/cc @cockroachdb/release
Deadlocks in a workload are rare (and bad) enough that they should be logged at the level of Info, instead of under vmodule.
Epic: none
Release note: None
Release justification: low-risk obs change.