Skip to content

Commit

Permalink
txnwait: do not require vmodule to log deadlocks in a workload
Browse files Browse the repository at this point in the history
Deadlocks in a workload are rare (and bad) enough that they should be
logged at the level of Info, instead of under vmodule.

Epic: none

Release note: None
  • Loading branch information
arulajmani committed Mar 22, 2023
1 parent a930643 commit 4b2b4b8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/kv/kvserver/txnwait/queue.go
Original file line number Diff line number Diff line change
Expand Up @@ -719,9 +719,8 @@ func (q *Queue) waitForPush(
// Break the deadlock if the pusher has higher priority.
p1, p2 := pusheePriority, pusherPriority
if p1 < p2 || (p1 == p2 && bytes.Compare(req.PusheeTxn.ID.GetBytes(), req.PusherTxn.ID.GetBytes()) < 0) {
log.VEventf(
log.Infof(
ctx,
1,
"%s breaking deadlock by force push of %s; dependencies=%s",
req.PusherTxn.ID.Short(),
req.PusheeTxn.ID.Short(),
Expand Down

0 comments on commit 4b2b4b8

Please sign in to comment.