sql/importer: unskip TestCSVImportCanBeResumed #94010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
reviewed
Dec 21, 2022
| @@ -668,6 +664,7 @@ func TestCSVImportCanBeResumed(t *testing.T) { | |||
| BulkAdderFlushesEveryBatch: true, | |||
| }, | |||
| }, | |||
| SQLMemoryPoolSize: 1 << 30, // 1 GiB | |||
There was a problem hiding this comment.
This LGTM, but I think in other places we've dropped how much kv.bulk_ingest.pk_buffer_size asks for to begin with to prevent the memory monitor from shouting at us.
This unskips the test and adds a memory limit. The test completed 1500+ runs under stress. I believe cockroachdb#93782 resolved the main source of flakiness here. Fixes cockroachdb#91828 Release note: None
stevendanna
force-pushed
the
unskip-TestCSVImportCanBeResumed
branch
from
76e7646 to
d522dab
Compare
|
Test failures look unrelated: bors r=rafiss |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unskips the test and adds a memory limit. The test completed 1500+ runs under stress. I believe #93782 resolved the main source of flakiness here.
Fixes #91828
Release note: None