importer: use ctx in progress push, use ctxgroup #93782
Conversation
|
This change is |
This ensures that goroutines started in the importer are shut down when the processor is shut down. While the previous comment indicates there is no need to wait on the goroutine, that isn't true in the case of cancellation in which the existing coordination is insufficient. Informs cockroachdb#91418 Release note: None
stevendanna
force-pushed
the
import-ctx-group
branch
from
b46922c to
c75676d
Compare
|
bors r=adityamaru |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from c75676d to blathers/backport-release-22.1-93782: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from c75676d to blathers/backport-release-22.2-93782: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
Just double checking if there are still plans to backport this? |
This unskips the test and adds a memory limit. The test completed 1500+ runs under stress. I believe cockroachdb#93782 resolved the main source of flakiness here. Fixes cockroachdb#91828 Release note: None
This unskips the test and adds a memory limit. The test completed 1500+ runs under stress. I believe cockroachdb#93782 resolved the main source of flakiness here. Fixes cockroachdb#91828 Release note: None
94010: sql/importer: unskip TestCSVImportCanBeResumed r=rafiss a=stevendanna This unskips the test and adds a memory limit. The test completed 1500+ runs under stress. I believe #93782 resolved the main source of flakiness here. Fixes #91828 Release note: None 94345: storage: include range key stats in ScanStats r=erikgrinaker a=jbowens Include the new, low-level Pebble range key iterator stats (introduced in cockroachdb/pebble#1871) in roachpb.ScanStats. Informs #77580. Close #93326. Epic: None Release note: None 94458: logictest: fix flakes from mixed version testing r=ZhouXing19 a=rafiss fixes #92637 The main fix was to wait for each node to be reachable before beginning the upgrade process. This also includes a version bump that has better logging to make it easier to debug. Release note: None Co-authored-by: Steven Danna <[email protected]> Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
This ensures that goroutines started in the importer are shut down
when the processor is shut down.
While the previous comment indicates there is no need to wait on the
goroutine, that isn't true in the case of cancellation in which the
existing coordination is insufficient.
Informs #91418
Release note: None