Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/workloadccl: BenchmarkImportFixture fails with memory budget exceeded #96013

Closed
Tracked by #96960
herkolategan opened this issue Jan 26, 2023 · 2 comments · Fixed by #103578
Closed
Tracked by #96960

ccl/workloadccl: BenchmarkImportFixture fails with memory budget exceeded #96013

herkolategan opened this issue Jan 26, 2023 · 2 comments · Fixed by #103578
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). T-sql-queries SQL Queries Team

Comments

@herkolategan
Copy link
Collaborator

herkolategan commented Jan 26, 2023

--- FAIL: BenchmarkImportFixture/tpcc/warehouses=1
    bench_test.go:42: 
        	Error Trace:	/mnt/data1/microbench/pkg/ccl/workloadccl/bin/bench_test.go:42
        	            				/mnt/data1/microbench/pkg/ccl/workloadccl/bin/bench_test.go:55
        	            				/mnt/data1/microbench/pkg/ccl/workloadccl/bin/benchmark.go:193
        	            				/mnt/data1/microbench/pkg/ccl/workloadccl/bin/benchmark.go:233
        	            				/mnt/data1/microbench/pkg/ccl/workloadccl/bin/asm_amd64.s:1594
        	Error:      	Received unexpected error:
        	            	importing table history: pq: not enough memory available to create a BulkAdder: root: memory budget exceeded: 33554432 bytes requested, 103008256 currently allocated, 134217728 bytes in budget
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/ccl/workloadccl.ImportFixture.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/ccl/workloadccl/fixture.go:404
        	            	  | github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx.func1
        	            	  | 	github.com/cockroachdb/cockroach/pkg/util/ctxgroup/ctxgroup.go:168
        	            	  | golang.org/x/sync/errgroup.(*Group).Go.func1
        	            	  | 	golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75
        	            	  | runtime.goexit
        	            	  | 	GOROOT/src/runtime/asm_amd64.s:1594
        	            	Wraps: (2) importing table history
        	            	Wraps: (3) pq: not enough memory available to create a BulkAdder: root: memory budget exceeded: 33554432 bytes requested, 103008256 currently allocated, 134217728 bytes in budget
        	            	Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *pq.Error
        	Test:       	BenchmarkImportFixture/tpcc/warehouses=1
--- FAIL: BenchmarkImportFixture
FAIL

Note:

pq: not enough memory available to create a BulkAdder: root: memory budget exceeded: 33554432

To reproduce:

./dev bench pkg/ccl/workloadccl -f=BenchmarkImportFixture --ignore-cache --bench-time=1s --verbose --stream-output --timeout 120m

Jira issue: CRDB-23895

@herkolategan herkolategan added C-test-failure Broken test (automatically or manually discovered). T-testeng TestEng Team labels Jan 26, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 26, 2023

cc @cockroachdb/test-eng

@srosenberg
Copy link
Member

Reducing ingest buffer sizes should address the memory issue [1]. My understanding is some recent change is allocating several more MBs when using a TestServer, subsequently causing the total SQL execution memory budget to be exceeded.

[1] #94010

@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Mar 2, 2023
@srosenberg srosenberg removed the T-testeng TestEng Team label Mar 2, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label May 15, 2023
@yuzefovich yuzefovich removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 15, 2023
@yuzefovich yuzefovich self-assigned this May 18, 2023
@craig craig bot closed this as completed in 054f8dc May 18, 2023
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants