Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: workload/schemachanger: correctly filter out unknown schema change errors #89883

Merged
merged 2 commits into from
Oct 13, 2022
Merged

release-22.2: workload/schemachanger: correctly filter out unknown schema change errors #89883

merged 2 commits into from
Oct 13, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 13, 2022 •
edited by fqazi
Loading

Backport 2/2 commits from #89858 on behalf of @fqazi.

/cc @cockroachdb/release

When code was added to handle unknown schema errors inside the schemachanger workload, the
regex used had a flaw that did not correctly quote the errors allowing no retries to occur. This meant
we never address the original errors but just avoided them due to low probability.

This PR also cleans up some debug code accidentally added in an older PR.

Release justification: low risk removes log spam and fixes a workload

fqazi added 2 commits October 12, 2022 19:36
@fqazi
sql: remove debug code for unknown schema errors
9c7e74f 
Fixes: #89859

In a previous PR some debug code was accidentally introduced
for unknown schema errors. These changes remove that
debug code.

Release note: None
@fqazi
workload/scheamchanger: fix unknown schema retry detection
d603550 
Fixes: #89146

Previously, when we added logic to retry unknown schema errors,
the regex used was unfortunately out of sync with the actual
error generated. This patch fixes the regex to have the correct
string, since those errors were not properly retried.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-89858 branch from 3d9d55e to d603550 Compare October 13, 2022 01:34
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 13, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 13, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi merged commit a75ea81 into release-22.2 Oct 13, 2022
@fqazi fqazi deleted the blathers/backport-release-22.2-89858 branch October 13, 2022 15:42
This was referenced Oct 13, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@fqazi fqazi Awaiting requested review from fqazi

@renatolabs renatolabs Awaiting requested review from renatolabs

Assignees

@fqazi fqazi

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @chengxiong-ruan @fqazi