workload/schemachanger: correctly filter out unknown schema change errors #89858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Fixes: cockroachdb#89859 In a previous PR some debug code was accidentally introduced for unknown schema errors. These changes remove that debug code. Release note: None
fqazi
force-pushed
the
unknownSchemaRetry
branch
from
ca888b6 to
43efc90
Compare
fqazi
added
branch-release-22.2
chengxiong-ruan
approved these changes
Oct 12, 2022
| @@ -1116,7 +1116,7 @@ SELECT count(*) FROM %s | |||
| } | |||
|
|
|||
| var ( | |||
| regexpUnknownSchemaErr = regexp.MustCompile(`unknown schema \[\d+\]`) | |||
| regexpUnknownSchemaErr = regexp.MustCompile(`unknown schema "\[\d+]"`) | |||
There was a problem hiding this comment.
just want to confirm that we're trying to match something like unknown schema "[1]" ?
There was a problem hiding this comment.
Yes the errors have the form: unknown schema "[1]". I'll add a comment to make it clear
Fixes: cockroachdb#89146 Previously, when we added logic to retry unknown schema errors, the regex used was unfortunately out of sync with the actual error generated. This patch fixes the regex to have the correct string, since those errors were not properly retried. Release note: None
fqazi
force-pushed
the
unknownSchemaRetry
branch
from
43efc90 to
900b38c
Compare
|
@chengxiong-ruan TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When code was added to handle unknown schema errors inside the schemachanger workload, the
regex used had a flaw that did not correctly quote the errors allowing no retries to occur. This meant
we never address the original errors but just avoided them due to low probability.
This PR also cleans up some debug code accidentally added in an older PR.