Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: reduce log spam from unknown schema errors #89859

Closed
fqazi opened this issue Oct 12, 2022 · 0 comments
Closed

sql: reduce log spam from unknown schema errors #89859

fqazi opened this issue Oct 12, 2022 · 0 comments
Assignees
@fqazi
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@fqazi
Copy link
Collaborator

fqazi commented Oct 12, 2022 •
edited by cockroach-jira-scripts
Loading

One of the older PR's to help track down issues inside the randomized schema changer workload accidentally added debug code inside unknown. schema errors that could lead to log spam. See:

cockroach/pkg/sql/sqlerrors/errors.go

Line 112 in ea43f89

log.Errorf(context.Background(), "MISSING SCHEMA: %s", debug.Stack())

Jira issue: CRDB-20467
@fqazi fqazi added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 labels Oct 12, 2022
@fqazi fqazi self-assigned this Oct 12, 2022
@craig craig bot closed this as completed in 740e0ca Oct 13, 2022
blathers-crl bot pushed a commit that referenced this issue Oct 13, 2022
@fqazi
sql: remove debug code for unknown schema errors
9c7e74f 
Fixes: #89859

In a previous PR some debug code was accidentally introduced
for unknown schema errors. These changes remove that
debug code.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fqazi