sql: reduce job times for randomized syntax change tests #88535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: cockroachdb#86366, cockroachdb#87569 Previously, the exponential back off time for randomized syntax change tests was 20 seconds, which was inappropriate for some randomized tests, since transaction retry errors could lead to schema changes taking a really long time. This could cause the test to fail with timeout errors, since we would incorrectly think that connections were hung. To address this, this patch makes the exponential back off configurable for the purpose of testing. Release note: None
|
This change is |
ajwerner
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi)
rafiss
approved these changes
Oct 3, 2022
|
bors r+ |
|
Build succeeded: |
This was referenced Oct 3, 2022
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating PR, but backport branch blathers/backport-deprecate-release-22.1.0-88535 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls: 422 Validation Failed [{Resource:PullRequest Field:base Code:invalid Message:}] Backport to branch 22.1.0 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
blathers backport 22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #86366
Fixes #87569
Previously, the exponential back off time for randomized syntax change tests was 20 seconds, which was inappropriate for some randomized tests, since transaction retry errors could lead to schema changes taking a really long time. This could cause the test to fail with timeout errors, since we would incorrectly think that connections were hung. To address this, this patch
makes the exponential back off configurable for the purpose of testing.
Release note: None
Release justification: low risk change to improve test stability