Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/tests: TestRandomSyntaxSchemaChangeDatabase failed #87569

Closed
cockroach-teamcity opened this issue Sep 8, 2022 · 2 comments · Fixed by #88535
Closed

sql/tests: TestRandomSyntaxSchemaChangeDatabase failed #87569

cockroach-teamcity opened this issue Sep 8, 2022 · 2 comments · Fixed by #88535
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
22.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 8, 2022 •
edited by cockroach-jira-scripts
Loading

sql/tests.TestRandomSyntaxSchemaChangeDatabase failed with artifacts on release-22.1 @ ad4b21c4707741e4b53fdc77a1fe01b1a8ac6fa5:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        DROP DATABASE CHARACTERISTICS;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-19414
@cockroach-teamcity cockroach-teamcity added branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Sep 8, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.1 milestone Sep 8, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Sep 8, 2022
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeDatabase failed with artifacts on release-22.1 @ c4c0f593f93353c2943a15c87479524aba6f811c:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        DROP DATABASE ident RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ajwerner
Copy link
Contributor

Some of these timeouts are just statements piling up. Another is a bug of sorts in the declarative schema changer whereby some descriptor disappears from under us?

fqazi added a commit to fqazi/cockroach that referenced this issue Sep 22, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
34f527a 
Fixes: cockroachdb#86366, cockroachdb#87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
@fqazi fqazi mentioned this issue Sep 22, 2022
Closed
fqazi added a commit to fqazi/cockroach that referenced this issue Sep 23, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
5bd588e 
Fixes: cockroachdb#86366, cockroachdb#87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
@fqazi fqazi mentioned this issue Sep 23, 2022
Merged
@craig craig bot closed this as completed in b5e54ff Oct 3, 2022
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Closed
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
6435601 
Fixes: #86366, #87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
7d18636 
Fixes: #86366, #87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
e6ab7c7 
Fixes: #86366, #87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Merged
@healthy-pod healthy-pod added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 17, 2023
@healthy-pod healthy-pod removed the T-sql-schema-deprecated Use T-sql-foundations instead label May 17, 2023
@exalate-issue-sync exalate-issue-sync bot reopened this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
22.1
Development

Successfully merging a pull request may close this issue.

sql: reduce job times for randomized syntax change tests fqazi/cockroach
3 participants
@ajwerner @cockroach-teamcity @healthy-pod