Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/tests: TestRandomSyntaxSchemaChangeColumn failed #86366

Closed
cockroach-teamcity opened this issue Aug 18, 2022 · 47 comments · Fixed by #88535
Closed

sql/tests: TestRandomSyntaxSchemaChangeColumn failed #86366

cockroach-teamcity opened this issue Aug 18, 2022 · 47 comments · Fixed by #88535
Assignees
@fqazi
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
22.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 18, 2022 •
edited by cockroach-jira-scripts
Loading

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 760a8253ae6478d69da0330133e3efec8e950e4e:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER COLUMN COALESCE SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-18717
@cockroach-teamcity cockroach-teamcity added branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Aug 18, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.1 milestone Aug 18, 2022
@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 18, 2022
Closed
@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 19, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 08bc326ba8e877a0e62fe4b3cbd4320882aecda3:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN NOCONTROLCHANGEFEED CHAR VARYING [ ];
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 1985775e222793428fbadf4dd3e2e4aba89ad6e7:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER INT SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 1985775e222793428fbadf4dd3e2e4aba89ad6e7:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER COLUMN TIME SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 1985775e222793428fbadf4dd3e2e4aba89ad6e7:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP OPT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 714fa0ad80c499cbd96ba97c560a9b414c61104f:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER ident SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Aug 23, 2022
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 5b20043919860dbf896247ed1bcf9480972c7998:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD STDIN STRING ( 312 ) ARRAY CREATE FAMILY POINTM;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ f81f08fc08acd9cd1e0017890d82606741a744f5:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER COLUMN STRING SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ fa6b3adbc5f1e3b85e99a88ca71da11213c8b25a:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN TRIM CHAR ( 344 ) ARRAY;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 7fe45c583432ecb053843b15ed602b71b6261499:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD IF NOT EXISTS ident VARBIT ( 26 ) ARRAY;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ fd04c2f3d7675d5a4a5a6c7d0c53cc502b019529:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP COLUMN IF EXISTS NULLIF;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ d6511dce69b90c2160ad9e62090e22ed47cee420:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER COLUMN ident SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ ff9b1bf2604b343c886667e3961a08814de316b5:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER COLUMN ident SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ f0da2ccc9f3641e4b8252dced7b3c42dca2f2dc1:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP DEC RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 5e2f4ff465491982e869cfb113fe9d73a087b081:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP GREATEST RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ a6c3138c2ab50b466ae1cc40409aa6a3b403129d:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN IF NOT EXISTS TIMESTAMPTZ INTERVAL [ 433 ] CREATE FAMILY;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ a6c3138c2ab50b466ae1cc40409aa6a3b403129d:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP IF EXISTS INCREMENTAL_LOCATION RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 443dd822332bb6487c949efbd9a4b700693850d4:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD KMS DATE ARRAY NOT VISIBLE CREATE FAMILY SUBSTRING;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 443dd822332bb6487c949efbd9a4b700693850d4:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN ident VARBIT ( 419 ) ARRAY;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 114900353a8471db38dadd56cd9358f498d615fb:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP COLUMN ident RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 12f2054de9a27ee1a155374d932ad7ee073d7130:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN IF NOT EXISTS MATCH VARBIT ( 419 );
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 12f2054de9a27ee1a155374d932ad7ee073d7130:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN IF NOT EXISTS TIMESTAMP INTERVAL ARRAY [ 176 ];
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 12f2054de9a27ee1a155374d932ad7ee073d7130:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN IF NOT EXISTS ident VARBIT ( 158 ) ARRAY;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 9eb4da2a351b2fe4706be9aa4af27ee2e60b405e:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN COMPLETIONS INTERVAL YEAR TO MONTH ARRAY [ 384 ];
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ 874f9b1a44d0c024153c3d835c3ca39c08338963:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD COLUMN IMMEDIATE STRING ARRAY [ 67 ] CREATE IF NOT EXISTS FAMILY AGGREGATE;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ fde59b70f5eb5a4252a8962bd2bdf0050e776cb3:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD REGION INTERVAL HOUR;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ a87b3d08895c6f08f5466b530eb8aed3669187fd:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ADD VIEWACTIVITYREDACTED BIT ( 48 ) CREATE FAMILY;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ a769b09b2f664a04b5bf513a12eb21bdbfdb7ca3:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER COLUMN GREATEST SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ a769b09b2f664a04b5bf513a12eb21bdbfdb7ca3:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident DROP COLUMN ident;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxSchemaChangeColumn failed with artifacts on release-22.1 @ a769b09b2f664a04b5bf513a12eb21bdbfdb7ca3:

Random syntax error:

    rsg_test.go:845: Crash detected: server panic: statement exec timeout

Query:

        ALTER TABLE ident.ident ALTER ident SET NOT NULL;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi @HonoreDB
Merge #88535 #89124
b5e54ff 
88535: sql: reduce job times for randomized syntax change tests r=fqazi a=fqazi

Fixes: #86366
Fixes #87569

Previously, the exponential back off time for randomized syntax change tests was 20 seconds, which was inappropriate for some randomized tests, since transaction retry errors could lead to schema changes taking a really long time. This could cause the test to fail with timeout errors, since we would incorrectly think that connections were hung. To address this, this patch
makes the exponential back off configurable for the purpose of testing.

Release note: None
Release justification: low risk change to improve test stability

89124: builtins: allow null in enum_* functions r=[rafiss] a=HonoreDB

Our enum functions don't quite have parity with their Postgres equivalents. Even though all they need is the type of their argument, they still evaluate it and error if the result is null. This PR fixes that, not in the ambitious way suggested in #78358 of persisting type info on nulls, but in the more limited way of changing the function implementations to act on their arguments after type resolution but before evaluation.

Informs #78358

Release note (sql change): enum_first, enum_last, and enum_range may now take null arguments as long as their type can be inferred from the expression.
Example: select num_first(null::switch);

Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: Aaron Zinger <[email protected]>
@craig craig bot closed this as completed in 5bd588e Oct 3, 2022
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Closed
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
6435601 
Fixes: #86366, #87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
7d18636 
Fixes: #86366, #87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
@fqazi
sql: reduce job times for randomized syntax change tests
e6ab7c7 
Fixes: #86366, #87569

Previously, the exponential back off time for randomized
syntax change tests was 20 seconds, which was inappropriate
for some randomized tests, since transaction retry errors
could lead to schema changes taking a really long time.
This could cause the test to fail with timeout errors,
since we would incorrectly think that connections were
hung. To address this, this patch
makes the exponential back off configurable for the
purpose of testing.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot reopened this May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss rafiss closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
22.1
Development

Successfully merging a pull request may close this issue.

sql: reduce job times for randomized syntax change tests fqazi/cockroach
3 participants
@rafiss @fqazi @cockroach-teamcity