Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: update activerecord adapter to v6.1.10 #81190

Merged
merged 1 commit into from
May 14, 2022
Merged

roachtest: update activerecord adapter to v6.1.10 #81190

merged 1 commit into from
May 14, 2022

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented May 11, 2022

refs #67893
refs #80777

This version correctly disables supports_expression_index to
prevent ON CONFLICT expression from appearing in generated
SQL statements.

Release note: None

@ecwall
roachtest: update activerecord adapter to v6.1.10
330034b 
refs #67893
refs #80777

This version correctly disables supports_expression_index to
prevent `ON CONFLICT expression` from appearing in generated
SQL statements.

Release note: None
@ecwall ecwall requested a review from rafiss May 11, 2022 13:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall requested review from otan and RichardJCai May 12, 2022 20:05
@rafiss
Copy link
Collaborator

rafiss commented May 12, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented May 13, 2022

Build failed:

@rafiss
Copy link
Collaborator

rafiss commented May 14, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented May 14, 2022

Build succeeded:

@craig craig bot merged commit 16c484a into cockroachdb:master May 14, 2022
@blathers-crl blathers-crl bot mentioned this pull request May 14, 2022
Closed
@rafiss
Copy link
Collaborator

rafiss commented May 16, 2022

blathers backport 22.1

@blathers-crl blathers-crl bot mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

@rafiss rafiss Awaiting requested review from rafiss

@RichardJCai RichardJCai Awaiting requested review from RichardJCai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecwall @cockroach-teamcity @rafiss @otan