-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: support expressions as ON CONFLICT targets #67893
sql: support expressions as ON CONFLICT targets #67893
Comments
@ianjevans this will likely be a known limitation for expression indexes in the 21.2 release. |
These flags can be enabled after this is fixed: cockroachdb/activerecord-cockroachdb-adapter#250 |
I don't think the linked PR fixes this issue. Reopening. |
79623: sql: add virtual indexes to crdb_internal.cluster_locks virtual table r=AlexTalks a=AlexTalks This change adds virtual indexes on the `table_id`, `database_name`, and `table_name` columns of the `crdb_internal.cluster_locks` virtual table, so that when queried, the `kv.Batch`es with `QueryLocksRequest`s can be constrained to query only specific tables or databases. This allows the requests to be much more limited, rather than needing to request all of the ranges that comprise the key spans of all tables accessible by the user. Release note (sql change): Improved query performance for `crdb_internal.cluster_locks` when issued with constraints in the WHERE clause on `table_id`, `database_name`, or `table_name` columns. Depends on #77876, #80422 80832: kvserver: IsCompleteTransaction might panic with certain batch sequences r=shralex a=shralex It's unclear how this panic happened. One possibility is that EntTxn had a negative sequence number. Another hypothesis is that ba.Requests was concurrently mutated due to a data race. This happened once, so for now adding more info to the panic. Release note: None Jira issue: https://cockroachlabs.atlassian.net/browse/CRDB-14627 81190: roachtest: update activerecord adapter to v6.1.10 r=rafiss a=ecwall refs #67893 refs #80777 This version correctly disables supports_expression_index to prevent `ON CONFLICT expression` from appearing in generated SQL statements. Release note: None 81193: storage: upgrade to pebblev2 table format r=jbowens,nicktrav a=erikgrinaker Resubmit of #76780, which was partially reverted for 22.1. --- The `Pebblev2` SSTable format adds support for range keys. Add two new cluster versions to provide the upgrade path - the first version for bumping the store, the second for use as a feature gate. Release note: None 81207: ttljob: fix a range edge case r=rafiss a=otan See individual commits for details. Refs: #81208 Co-authored-by: Alex Sarkesian <[email protected]> Co-authored-by: shralex <[email protected]> Co-authored-by: Evan Wall <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Oliver Tan <[email protected]>
We have marked this issue as stale because it has been inactive for |
We don't currently support expressions as
ON CONFLICT
targets. This means that unique expression indexes (still a WIP at the time this was written) cannot be selected as arbiters forINSERT .. ON CONFLICT
statements. This will require adding support for expressionON CONFLICT
targets to the parser and the AST, and updating optbuilder's arbiter logic to select arbiters based on the expression.Example:
Jira issue: CRDB-8765
The text was updated successfully, but these errors were encountered: