Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: activerecord failed #80777

Closed
cockroach-teamcity opened this issue Apr 29, 2022 · 11 comments · Fixed by cockroachdb/activerecord-cockroachdb-adapter#250
Closed

roachtest: activerecord failed #80777

cockroach-teamcity opened this issue Apr 29, 2022 · 11 comments · Fixed by cockroachdb/activerecord-cockroachdb-adapter#250
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Apr 29, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.activerecord failed with artifacts on master @ 97e72bacbeb9574f09f7475a62ef45c3e228183e:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1338-g97e72bacbe
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6647 tests passed
		1 test failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-15517
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Apr 29, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Apr 29, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ a2e1910f51593bd2ef72e1d7c615e08f95791186:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1379-ga2e1910f51
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6647 tests passed
		1 test failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity mentioned this issue Apr 30, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ c9e0194b19a03d55c6be92572aad3fbafc256334:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1381-gc9e0194b19
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6647 tests passed
		1 test failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 7a9eb906ce86e2f75db637e29d46cd6604fca7b4:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1389-g7a9eb906ce
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6646 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: BasicsTest#test_default_values_are_deeply_dupped (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@otan otan removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. blocks-22.1.0-rc.1 labels May 3, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 01572daaf94f80f81f843723a8b58d80fe128990:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1436-g01572daaf9
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6647 tests passed
		1 test failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ b01e1f3b3db311603dc7dd63647a8a737602143e:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1478-gb01e1f3b3d
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6647 tests passed
		1 test failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ecwall ecwall mentioned this issue May 4, 2022
Merged
@cockroach-teamcity cockroach-teamcity mentioned this issue May 5, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 587302906426907122deae6eae5f68630d57e900:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1514-g5873029064
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6646 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 98bdf3241028c9b1bdff429fb455e61870adc9d0:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1538-g98bdf32410
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6646 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

This was referenced May 6, 2022
Closed
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ a86e6c9c4b82cb404e4a20fa70092823fd4a9439:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1557-ga86e6c9c4b
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6646 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 60d0f95ba057dab8d4f50d2903c504fe275d061a:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1561-g60d0f95ba0
		Tests run against activerecord 6.1.5
		6648 Total Tests Run
		6646 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 1a91d7cb7b93dfef5dcaf872125875cefa3e0190:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1578-g1a91d7cb7b
		Tests run against activerecord 6.1.5
		6664 Total Tests Run
		6662 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 7f3c06f5f2c26bc84705430a3622f92ec1444e9d:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1580-g7f3c06f5f2
		Tests run against activerecord 6.1.5
		6664 Total Tests Run
		6662 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ecwall ecwall mentioned this issue May 11, 2022
Merged
craig bot pushed a commit that referenced this issue May 14, 2022
@AlexTalks @shralex
@ecwall @erikgrinaker @otan
Merge #79623 #80832 #81190 #81193 #81207
16c484a 
79623: sql: add virtual indexes to crdb_internal.cluster_locks virtual table  r=AlexTalks a=AlexTalks

This change adds virtual indexes on the `table_id`, `database_name`, and
`table_name` columns of the `crdb_internal.cluster_locks` virtual table,
so that when queried, the `kv.Batch`es with `QueryLocksRequest`s can be
constrained to query only specific tables or databases. This allows the
requests to be much more limited, rather than needing to request all of
the ranges that comprise the key spans of all tables accessible by the
user.

Release note (sql change): Improved query performance for
`crdb_internal.cluster_locks` when issued with constraints in the WHERE
clause on `table_id`, `database_name`, or `table_name` columns.

Depends on #77876, #80422

80832: kvserver: IsCompleteTransaction might panic with certain batch sequences r=shralex a=shralex

It's unclear how this panic happened. One possibility is that EntTxn had a negative sequence number. Another hypothesis is that ba.Requests was concurrently mutated due to a data race. This happened once, so for now adding more info to the panic.

Release note: None

Jira issue: https://cockroachlabs.atlassian.net/browse/CRDB-14627

81190: roachtest: update activerecord adapter to v6.1.10 r=rafiss a=ecwall

refs #67893
refs #80777

This version correctly disables supports_expression_index to
prevent `ON CONFLICT expression` from appearing in generated
SQL statements.

Release note: None

81193: storage: upgrade to pebblev2 table format r=jbowens,nicktrav a=erikgrinaker

Resubmit of #76780, which was partially reverted for 22.1.

---

The `Pebblev2` SSTable format adds support for range keys. Add two new
cluster versions to provide the upgrade path - the first version for
bumping the store, the second for use as a feature gate.

Release note: None

81207: ttljob: fix a range edge case r=rafiss a=otan

See individual commits for details.

Refs: #81208

Co-authored-by: Alex Sarkesian <[email protected]>
Co-authored-by: shralex <[email protected]>
Co-authored-by: Evan Wall <[email protected]>
Co-authored-by: Erik Grinaker <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
@blathers-crl blathers-crl bot mentioned this issue May 14, 2022
Closed
blathers-crl bot pushed a commit that referenced this issue May 14, 2022
@ecwall
roachtest: update activerecord adapter to v6.1.10
4c454ee 
refs #67893
refs #80777

This version correctly disables supports_expression_index to
prevent `ON CONFLICT expression` from appearing in generated
SQL statements.

Release note: None
blathers-crl bot pushed a commit that referenced this issue May 16, 2022
@ecwall
roachtest: update activerecord adapter to v6.1.10
3e8a0d7 
refs #67893
refs #80777

This version correctly disables supports_expression_index to
prevent `ON CONFLICT expression` from appearing in generated
SQL statements.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable supports_expression_index unconditionally
4 participants
@jlinder @celiala @otan @cockroach-teamcity