sql: use 'NONVOTERS' as keyword for 'RELOCATE', not 'NON_VOTERS' #73802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idiom for positional keywords in SQL is to either use words separated by spaces (e.g. NOT NULL), or to concatenate the words together (ISERROR, NOLOGIN, LINESTRING). Release note (sql change): In the experimental RELOCATE syntax forms, the positional keyword that indicates that the statement should move non-voter replicas is now spelled `NONVOTERS`, instead of `NON_VOTERS` previously.
|
This change is |
Release note (sql change): The inline help for the ALTER statements now mentions the RELOCATE syntax.
knz
force-pushed
the
20211214-relocate-simplify
branch
from
de70504 to
393268c
Compare
|
thank you, seems like this will resolve #63219 |
RaduBerinde
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @arulajmani and @lunevalex)
rafiss
approved these changes
Dec 14, 2021
There is no need for separate non-terminals for the 'LEASE' variants of RELOCATE. This commit deletes them. Release note: None
knz
force-pushed
the
20211214-relocate-simplify
branch
from
393268c to
d416008
Compare
|
TFYR! bors r=rafiss,RaduBerinde |
otan
reviewed
Dec 14, 2021
|
ordinarily yes, but this is both an experimental feature, and also only intended for internal use. |
knz
added a commit
to knz/cockroach
that referenced
this pull request
Dec 14, 2021
a hiccup was introduced in cockroachdb#73802. Release note: None
lunevalex
approved these changes
Dec 14, 2021
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
73773: roachtest: add knex test r=rafiss a=otan These tests *will* fail on master as knex does not handle the PK/FK name rename correctly. However, this commit alone makes it backportable to v21.2, so this is being presented as is. Release note: None 73790: bench/rttanalysis: stop printing text trace, write jaeger r=ajwerner a=ajwerner This commit changes the behavior on failure of the rttanalysis tests. Before it would print a textual trace. That was pretty much useless and it was very loud. Now it'll write the jaeger trace json to a file in the logging directory. Hopefully that'll be more useful to inspect the difference between the expectation and the observed result. Release note: None 73812: sql: fix some help texts r=otan a=knz (first 3 commits from #73802.) a hiccup was introduced in #73802, but I don't want to cancel the CI / bors build to put the fix in, hence a new PR. Co-authored-by: Oliver Tan <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #73315.
Fixes #63219.
The idiom for positional keywords in SQL is to either use words
separated by spaces (e.g. NOT NULL), or to concatenate the words
together (ISERROR, NOLOGIN, LINESTRING).
Release note (sql change): In the experimental RELOCATE syntax
forms, the positional keyword that indicates that the statement
should move non-voter replicas is now spelled
NONVOTERS, insteadof
NON_VOTERSpreviously.Release note (sql change): The inline help for the ALTER
statements now mentions the RELOCATE syntax.