sql: use a 3-valued type instead of 2 booleans for relocate statements #73803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idiom for positional keywords in SQL is to either use words separated by spaces (e.g. NOT NULL), or to concatenate the words together (ISERROR, NOLOGIN, LINESTRING). Release note (sql change): In the experimental RELOCATE syntax forms, the positional keyword that indicates that the statement should move non-voter replicas is now spelled `NONVOTERS`, instead of `NON_VOTERS` previously.
|
This change is |
knz
force-pushed
the
20211214-kv-alter
branch
from
928009d to
dd9e307
Compare
Release note (sql change): The inline help for the ALTER statements now mentions the RELOCATE syntax.
knz
force-pushed
the
20211214-kv-alter
branch
from
dd9e307 to
4092554
Compare
RaduBerinde
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @arulajmani, @knz, and @lunevalex)
pkg/sql/sem/tree/alter_range.go, line 29 at r4 (raw file):
// RelocateSubject indicates what replicas of a range should be relocated. type RelocateSubject int
[supernit] It won't matter here, but it's good practice to use small types when they're sufficient (int8 here)
knz
force-pushed
the
20211214-kv-alter
branch
from
88161fe to
4092554
Compare
There is no need for separate non-terminals for the 'LEASE' variants of RELOCATE. This commit deletes them. Release note: None
By using a 3-valued types, we greatly simplify the code to print out statement types, and also clarify intent in all the conditionals that depend on the relocation mode. Release note: None
knz
commented
Dec 14, 2021
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/tree/alter_range.go, line 29 at r4 (raw file):
Previously, RaduBerinde wrote…
[supernit] It won't matter here, but it's good practice to use small types when they're sufficient (
int8here)
Good idea. Done.
knz
force-pushed
the
20211214-kv-alter
branch
from
4092554 to
285cce1
Compare
|
TFYR bors r=RaduBerinde |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #73315.
First 3 commits from #73802 (reviewers, focus on the last commit)
By using a 3-valued types, we greatly simplify the code to print out
statement types, and also clarify intent in all the conditionals that
depend on the relocation mode.