Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql,kv: SQL syntax for the RELOCATE statement is non-idiomatic #63219

Closed
knz opened this issue Apr 7, 2021 · 0 comments · Fixed by #73802
Closed

sql,kv: SQL syntax for the RELOCATE statement is non-idiomatic #63219

knz opened this issue Apr 7, 2021 · 0 comments · Fixed by #73802
Labels
A-kv-distribution Relating to rebalancing and leasing. A-sql-syntax Issues strictly related to the SQL grammar, with no semantic aspect C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@knz
Copy link
Contributor

knz commented Apr 7, 2021 •
edited
Loading

commits af80850 and af80850 have added the syntax RELOCATE VOTERS and RELOCATE NON_VOTERS

The prefix NON_ in front of a keyword is highly non-idiomatic for SQL: the goal of the SQL syntax it to use only standalone english words, and use adjectives/adverbs/prepositions to indicate inclusion/exclusion.

For this use case, the more idiomatic syntax would be:

  • RELOCATE ONLY VOTERS / RELOCATE VOTERS ONLY

  • RELOCATE EXCLUDING VOTERS / RELOCATE VOTERS EXCLUDED

Found while working on rebasing #60676.

cc @mwang1026 @aayushshah15 for triage.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-distribution Relating to rebalancing and leasing. A-sql-syntax Issues strictly related to the SQL grammar, with no semantic aspect labels Apr 7, 2021
@knz knz changed the title sql,kv: SQL syntax for the RELOCATE statement is non-idomatic sql,kv: SQL syntax for the RELOCATE statement is non-idiomatic Apr 7, 2021
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@jlinder jlinder added the T-kv KV Team label Jun 16, 2021
@rafiss rafiss mentioned this issue Dec 14, 2021
Merged
@rafiss rafiss linked a pull request Dec 14, 2021 that will close this issue
sql: use 'NONVOTERS' as keyword for 'RELOCATE', not 'NON_VOTERS' #73802
Merged
@craig craig bot closed this as completed in 7bf398f Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-distribution Relating to rebalancing and leasing. A-sql-syntax Issues strictly related to the SQL grammar, with no semantic aspect C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: use 'NONVOTERS' as keyword for 'RELOCATE', not 'NON_VOTERS' knz/cockroach
3 participants
@jlinder @knz @rafiss