bazel: glob-exclude all *_generated.go files from Gazelle #72099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
changed the title
rickystewart
force-pushed
the
_generated
branch
from
9710f17 to
306abad
Compare
rickystewart
changed the title
rickystewart
force-pushed
the
_generated
branch
5 times, most recently
from
d13bd47 to
ea4ee51
Compare
rail
approved these changes
Nov 1, 2021
|
bors r=rail |
|
bors r- |
|
Canceled. |
This will help ensure that Gazelle doesn't accidentally reference checked-in generated code. The generated code in `pkg/col/colserde/arrowserde` is made by `flatc`, the FlatBuffers compiler -- I tried to make a `genrule` to generate this code but the code that `flatc` generates now doesn't match up to what's checked in (maybe we used a different version of `flatc` for the original version of the code?) Closes cockroachdb#72096. Release note: None
rickystewart
force-pushed
the
_generated
branch
from
ea4ee51 to
df75249
Compare
|
bors r=rail |
|
Build failed: |
|
Flake. bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review is only for the second commit in the stack; the other is from #72098.
This will help ensure that Gazelle doesn't accidentally reference
checked-in generated code.
The generated code in
pkg/col/colserde/arrowserdeis made byflatc,the FlatBuffers compiler -- I tried to make a
genruleto generate thiscode but the code that
flatcgenerates now doesn't match up to what'schecked in (maybe we used a different version of
flatcfor theoriginal version of the code?)
Closes #72096.
Release note: None