Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: glob-exclude all *_generated.go files from Gazelle #72096

Closed
rickystewart opened this issue Oct 28, 2021 · 0 comments · Fixed by #72099
Closed

bazel: glob-exclude all *_generated.go files from Gazelle #72096

rickystewart opened this issue Oct 28, 2021 · 0 comments · Fixed by #72099
Assignees
@rickystewart
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

Epic CRDB-8036
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Oct 28, 2021
@rickystewart rickystewart self-assigned this Oct 28, 2021
@rickystewart rickystewart mentioned this issue Oct 28, 2021
Merged
rickystewart added a commit to rickystewart/cockroach that referenced this issue Oct 29, 2021
@rickystewart
bazel: glob-exclude all *_generated.go files from Gazelle
ea4ee51 
This will help ensure that Gazelle doesn't accidentally reference
checked-in generated code.

The generated code in `pkg/col/colserde/arrowserde` is made by `flatc`,
the FlatBuffers compiler -- I tried to make a `genrule` to generate this
code but the code that `flatc` generates now doesn't match up to what's
checked in (maybe we used a different version of `flatc` for the
original version of the code?)

Closes cockroachdb#72096.

Release note: None
craig bot pushed a commit that referenced this issue Nov 1, 2021
@rickystewart @irfansharif
Merge #72099 #72125 #72264
83ace64 
72099: bazel: glob-exclude all *_generated.go files from Gazelle r=rail a=rickystewart

This review is only for the second commit in the stack; the other is from #72098.

This will help ensure that Gazelle doesn't accidentally reference
checked-in generated code.

The generated code in `pkg/col/colserde/arrowserde` is made by `flatc`,
the FlatBuffers compiler -- I tried to make a `genrule` to generate this
code but the code that `flatc` generates now doesn't match up to what's
checked in (maybe we used a different version of `flatc` for the
original version of the code?)

Closes #72096.

Release note: None

72125: dev: pad internal timeouts when under --stress --timeout r=irfansharif a=irfansharif

I was seeing the earlier one second buffer being insufficient.

Release note: None

72264: Move metric scope library r=miretskiy a=miretskiy

This is move only PR which moves metrics scope library from
cdcutils directly under changefeedccl.

It is structured as add/remove PR so that the "add" portion can be easily backported.

Release Notes: None

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: Yevgeniy Miretskiy <[email protected]>
@craig craig bot closed this as completed in df75249 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel: glob-exclude all *_generated.go files from Gazelle rickystewart/cockroach
1 participant
@rickystewart