roachtest: fix up mockgen usage w/ Bazel
#72098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
roachtest_mocks
branch
from
a7e2a7c to
11711f1
Compare
|
I would review this, but have very little experience with bazel, and so my approval wouldn't amount to much. |
irfansharif
suggested changes
Oct 29, 2021
rickystewart
force-pushed
the
roachtest_mocks
branch
from
11711f1 to
a641cde
Compare
rickystewart
force-pushed
the
roachtest_mocks
branch
3 times, most recently
from
51bde41 to
1ffe6b5
Compare
irfansharif
approved these changes
Oct 29, 2021
| importpath = "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/prometheus", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "@com_github_golang_mock//gomock", # keep |
There was a problem hiding this comment.
[nit] Is the keep necessary?
We were pointing to the checked-in generated files in the Bazel build here; instead, use `gomock`. Also clean up the `EXISTING_GO_GENERATE_COMMENTS` in `build/bazelutil/check.sh`. Release note: None
rickystewart
force-pushed
the
roachtest_mocks
branch
from
1ffe6b5 to
a45418f
Compare
|
bors r=irfansharif |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
72099: bazel: glob-exclude all *_generated.go files from Gazelle r=rail a=rickystewart This review is only for the second commit in the stack; the other is from #72098. This will help ensure that Gazelle doesn't accidentally reference checked-in generated code. The generated code in `pkg/col/colserde/arrowserde` is made by `flatc`, the FlatBuffers compiler -- I tried to make a `genrule` to generate this code but the code that `flatc` generates now doesn't match up to what's checked in (maybe we used a different version of `flatc` for the original version of the code?) Closes #72096. Release note: None 72125: dev: pad internal timeouts when under --stress --timeout r=irfansharif a=irfansharif I was seeing the earlier one second buffer being insufficient. Release note: None 72264: Move metric scope library r=miretskiy a=miretskiy This is move only PR which moves metrics scope library from cdcutils directly under changefeedccl. It is structured as add/remove PR so that the "add" portion can be easily backported. Release Notes: None Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: irfan sharif <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were pointing to the checked-in generated files in the Bazel build
here; instead, use
gomock.Also clean up the
EXISTING_GO_GENERATE_COMMENTSinbuild/bazelutil/check.sh.Release note: None