Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authors: add xinhaoz to AUTHORS #67550

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Jul 13, 2021

Release note: None

@xinhaoz xinhaoz requested a review from rickystewart July 13, 2021 18:08
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 13, 2021

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz
Copy link
Member Author

xinhaoz commented Jul 13, 2021

bors r+

craig bot pushed a commit that referenced this pull request Jul 13, 2021
66560:  sql: allowing add missing tables from json file r=RichardJCai a=mnovelodou

 Previously, we could only add missing tables on information_schema or
 pg_catalog from dump json file
 This was inadequate because sometimes we need to manually decide how
 columns data types are going to be
 To address this, this patch adds a flag that allows to specify the json
 file where to find the missing tables

 Release note: None

67375: roachtest: ensure privileges stay consistent after version upgrades r=rafiss a=RichardJCai

roachtest: ensure privileges stay consistent after version upgrades

Release note: None

Resolves #65011

67548: roachtest: fix typeorm apt-get update r=rail a=RichardJCai

Release note: None

67550: authors: add xinhaoz to AUTHORS r=xinhaoz a=xinhaoz

Release note: None

67560: authors: add [email protected] to authors. r=rharding6373 a=rharding6373

Release note: None

Co-authored-by: MiguelNovelo <[email protected]>
Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: rharding6373 <[email protected]>
@craig
Copy link
Contributor

craig bot commented Jul 13, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 13, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 14, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 14, 2021

Build succeeded:

@craig craig bot merged commit 5a0b11e into cockroachdb:master Jul 14, 2021
@xinhaoz xinhaoz deleted the xinhao_authors branch August 16, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants