sql: allowing add missing tables from json file #66560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
mnovelodou
force-pushed
the
add_missing_columns
branch
from
ad6137e to
5e4736e
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
mnovelodou
force-pushed
the
add_missing_columns
branch
from
5e4736e to
e4f9838
Compare
RichardJCai
approved these changes
Jun 24, 2021
Previously, we could only add missing tables on information_schema or pg_catalog from dump json file This was inadequate because sometimes we need to manually decide how columns data types are going to be To address this, this patch adds a flag that allows to specify the json file where to find the missing tables Release note: None
mnovelodou
force-pushed
the
add_missing_columns
branch
from
e4f9838 to
6a117a4
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
66560: sql: allowing add missing tables from json file r=RichardJCai a=mnovelodou Previously, we could only add missing tables on information_schema or pg_catalog from dump json file This was inadequate because sometimes we need to manually decide how columns data types are going to be To address this, this patch adds a flag that allows to specify the json file where to find the missing tables Release note: None 67375: roachtest: ensure privileges stay consistent after version upgrades r=rafiss a=RichardJCai roachtest: ensure privileges stay consistent after version upgrades Release note: None Resolves #65011 67548: roachtest: fix typeorm apt-get update r=rail a=RichardJCai Release note: None 67550: authors: add xinhaoz to AUTHORS r=xinhaoz a=xinhaoz Release note: None 67560: authors: add [email protected] to authors. r=rharding6373 a=rharding6373 Release note: None Co-authored-by: MiguelNovelo <[email protected]> Co-authored-by: richardjcai <[email protected]> Co-authored-by: Xin Hao Zhang <[email protected]> Co-authored-by: rharding6373 <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we could only add missing tables on information_schema or
pg_catalog from dump json file
This was inadequate because sometimes we need to manually decide how
columns data types are going to be
To address this, this patch adds a flag that allows to specify the json
file where to find the missing tables
Release note: None