-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
66795: sql: added missing tables from mysql information_schema r=rafiss a=mnovelodou Previously, there was missing tables on information_schema present on mysql This was inadequate because it can cause compatibility problems To address this, this patch adds missing information_schema tables Release note (sql change): Added missing tables from mysql information_schema. The tables are not populated and are entirely empty. - column_statistics - columns_extensions - engines - events - files - keywords - optimizer_trace - partitions - plugins - processlist - profiling - resource_groups - schemata_extensions - st_geometry_columns - st_spatial_reference_systems - st_units_of_measure - table_constraints_extensions - tables_extensions - tablespaces - tablespaces_extensions - user_attributes 67326: rowexec: remove unnecessary joiner member r=andreimatei a=andreimatei The joiner had a field tracking a confusing lookup row index. Besides being confusing, this member obscured the fact that it was equal to the ordinal returned by inserting rows into a disk container - and thus that the respective ordinal is used. Release note: None 67514: sql,kv: permit txn rollbacks across LockNotAvailable errors r=nvanbenschoten a=nvanbenschoten This commit adds support for rolling a transaction back across a `LockNotAvailable` (pgcode 55P03) error. `LockNotAvailable` errors are returned in two cases: 1. when a locking SELECT is run with a NOWAIT wait policy and conflicts with an active lock 2. when a statement is run with a `lock_timeout` and this timeout is exceeded (unsupported, see #67513) The following test case from `pkg/sql/testdata/savepoints` demonstrates this new capability: ``` # txn1 BEGIN INSERT INTO t VALUES (1) ---- 1: BEGIN -- 0 rows -- NoTxn -> Open #. (none) 2: INSERT INTO t VALUES (1) -- 1 row -- Open -> Open ## (none) # txn2 BEGIN SAVEPOINT foo SELECT * FROM t WHERE x = 1 FOR UPDATE NOWAIT ROLLBACK TO SAVEPOINT foo SELECT * FROM t WHERE x = 2 FOR UPDATE NOWAIT COMMIT ---- 1: BEGIN -- 0 rows -- NoTxn -> Open #..... (none) 2: SAVEPOINT foo -- 0 rows -- Open -> Open ##.... foo 3: SELECT * FROM t WHERE x = 1 FOR UPDATE NOWAIT -- pq: could not obtain lock on row (x)=(1) in t@primary -- Open -> Aborted XXXXXX foo 4: ROLLBACK TO SAVEPOINT foo -- 0 rows -- Aborted -> Open ##.... foo 5: SELECT * FROM t WHERE x = 2 FOR UPDATE NOWAIT -- 0 rows -- Open -> Open ##..#. foo 6: COMMIT -- 0 rows -- Open -> NoTxn ##..## (none) ``` This becomes the second error type that supports rollbacks, with the first being duplicate key errors, which was added in 65e8045. The primary motivation for this PR was to be able to give `WriteIntentErrors` an `ErrorPriority` of `ErrorScoreUnambiguousError` for #66146. However, the added functionality fell out of making that change. Release note (sql change): ROLLBACK TO SAVEPOINT can now be used to recover from LockNotAvailable errors (pgcode 55P03), which are returned when performing a FOR UPDATE SELECT with a NOWAIT wait policy. 67524: limit,storage: add more trace spans to backup path r=dt a=adityamaru This change adds a trace recording to track how many requests are waiting in the the concurrent limiter queue. The change also adds a child span to ExportMVCCToSst to track how long the scan+SST creation is taking per ExportRequest during backup. Release note: None 67544: catalogkv: fix panic inside Txn swallowing retries r=postamar a=ajwerner `(*kv.DB).Txn` may produce retry errors. While it's fine that this test function can panic in the face of a real error, it's not okay to panic the retry error. Fixes #67213. Release note: None 67550: authors: add xinhaoz to AUTHORS r=xinhaoz a=xinhaoz Release note: None 67557: parser: reduce imports for scan.go r=otan a=rafiss See individual commits: - move keywords.go and tokens.go to lexbase - remove scan.go dependency on tree NewNumVal/NewStrVal Touches #64710 Co-authored-by: MiguelNovelo <[email protected]> Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Xin Hao Zhang <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
- Loading branch information
Showing
56 changed files
with
2,752 additions
and
1,191 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -380,6 +380,7 @@ Wade Waldron <[email protected]> | |
wenyong-h <[email protected]> | ||
Will Haack <[email protected]> <[email protected]> | ||
Xiang Li <[email protected]> | ||
Xin Hao Zhang <[email protected]> <[email protected]> | ||
Xinyu Zhou (Joe) <[email protected]> | ||
XisiHuang <[email protected]> | ||
xphoniex <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.