release-20.1: sql: fix internal error when trying to parse strings as arrays #59066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parse-constant-as-type code was allowing a desired type of `Array[Any]`, and we can't parse elements as `Any`. This resulted in an internal error, rather than a normal query error. Fixes cockroachdb#52134. Release note (bug fix): Fixed an internal error involving string literals used as arrays.
|
This change is |
yuzefovich
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
nit: maybe add the new issue #59024 into the PR description.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
|
TFTR, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #52416.
Fixes #59024.
/cc @cockroachdb/release
The parse-constant-as-type code was allowing a desired type of
Array[Any], andwe can't parse elements as
Any. This resulted in an internal error, ratherthan a normal query error.
Fixes #52134.
Release note (bug fix): Fixed an internal error involving string literals used
as arrays.