sql: fix internal error when trying to parse strings as arrays #52416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
reviewed
Aug 5, 2020
pkg/sql/sem/tree/constant.go
Outdated
| func typeCheckConstant( | ||
| ctx context.Context, semaCtx *SemaContext, c Constant, desired *types.T, | ||
| ) (ret TypedExpr, err error) { | ||
| avail := c.AvailableTypes() | ||
| if desired.Family() != types.AnyFamily { | ||
| if isDefiniteType(desired) { |
There was a problem hiding this comment.
I think we have a function typ.IsAmbiguous that does something like this already
The parse-constant-as-type code was allowing a desired type of `Array[Any]`, and we can't parse elements as `Any`. This resulted in an internal error, rather than a normal query error. Fixes cockroachdb#52134. Release note (bug fix): Fixed an internal error involving string literals used as arrays.
RaduBerinde
force-pushed
the
fix-array-parse-internal-err
branch
from
4d7b314 to
32522ea
Compare
RaduBerinde
commented
Aug 5, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan and @rohany)
pkg/sql/sem/tree/constant.go, line 79 at r1 (raw file):
Previously, rohany (Rohan Yadav) wrote…
I think we have a function
typ.IsAmbiguousthat does something like this already
Awesome!! Done.
rohany
approved these changes
Aug 5, 2020
otan
approved these changes
Aug 10, 2020
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parse-constant-as-type code was allowing a desired type of
Array[Any], andwe can't parse elements as
Any. This resulted in an internal error, ratherthan a normal query error.
Fixes #52134.
Release note (bug fix): Fixed an internal error involving string literals used
as arrays.