sql: v20.1.5: unknown type when parsing string as an array element

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/2153767188/?referrer=webhooks_plugin

Panic message:

*errors.errorString
*safedetails.withSafeDetails: unknown type %s (%T) (1)
parse_string.go:71: *withstack.withStack (2)
*assert.withAssertionFailure
*errutil.withMessage
*safedetails.withSafeDetails: could not parse %q as type %s (3)
datum.go:252: *withstack.withStack (4)
*pgerror.withCandidateCode: 22P02 (5)
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/sem/tree/parse_string.go

Lines 70 to 72 in f990441

	default:
	return nil, errors.AssertionFailedf("unknown type %s (%T)", t, t)
	}

in pkg/sql/sem/tree.ParseAndRequireString

cockroach/pkg/sql/sem/tree/parse_array.go

Lines 138 to 140 in f990441

	d, err := ParseAndRequireString(p.t, next, p.ctx)
	if err != nil {

in pkg/sql/sem/tree.(*parseState).parseElement

cockroach/pkg/sql/sem/tree/parse_array.go

Lines 173 to 175 in f990441

	if parser.peek() != '}' {
	if err := parser.parseElement(); err != nil {
	return nil, err

in pkg/sql/sem/tree.doParseDArrayFromString

cockroach/pkg/sql/sem/tree/parse_array.go

Lines 149 to 151 in f990441

	func ParseDArrayFromString(ctx ParseTimeContext, s string, t *types.T) (*DArray, error) {
	ret, err := doParseDArrayFromString(ctx, s, t)
	if err != nil {

in pkg/sql/sem/tree.ParseDArrayFromString

cockroach/pkg/sql/sem/tree/parse_string.go

Lines 23 to 25 in f990441

	case types.ArrayFamily:
	return ParseDArrayFromString(ctx, s, t.ArrayContents())
	case types.BitFamily:

in pkg/sql/sem/tree.ParseAndRequireString

cockroach/pkg/sql/sem/tree/constant.go

Lines 542 to 544 in f990441

	datum, err := ParseAndRequireString(typ, expr.s, ctx)
	return datum, err

in pkg/sql/sem/tree.(*StrVal).ResolveAsType

cockroach/pkg/sql/sem/tree/constant.go

Lines 64 to 66 in f990441

	if desired.Equivalent(typ) {
	return c.ResolveAsType(ctx, desired)
	}

in pkg/sql/sem/tree.typeCheckConstant

cockroach/pkg/sql/sem/tree/type_check.go

Lines 1234 to 1236 in f990441

	func (expr *StrVal) TypeCheck(ctx *SemaContext, desired *types.T) (TypedExpr, error) {
	return typeCheckConstant(expr, ctx, desired)
	}

in pkg/sql/sem/tree.(*StrVal).TypeCheck

cockroach/pkg/sql/sem/tree/type_check.go

Lines 502 to 504 in f990441

	subExpr, err := expr.Expr.TypeCheck(ctx, types.MakeArray(desired))
	if err != nil {

in pkg/sql/sem/tree.(*IndirectionExpr).TypeCheck

cockroach/pkg/sql/sem/tree/type_check.go

Lines 260 to 262 in f990441

	}
	return expr.TypeCheck(ctx, desired)
	}

in pkg/sql/sem/tree.TypeCheck

cockroach/pkg/sql/opt/optbuilder/scope.go

Lines 423 to 425 in f990441

	expr = s.walkExprTree(expr)
	texpr, err := tree.TypeCheck(expr, s.builder.semaCtx, desired)
	if err != nil {

in pkg/sql/opt/optbuilder.(*scope).resolveType

cockroach/pkg/sql/opt/optbuilder/project.go

Lines 149 to 151 in f990441

	texpr = inScope.resolveType(e.Expr, desired)
	}

in pkg/sql/opt/optbuilder.(*Builder).analyzeSelectList

cockroach/pkg/sql/opt/optbuilder/project.go

Lines 83 to 85 in f990441

	b.analyzeSelectList(selects, desiredTypes, inScope, outScope)
	}

in pkg/sql/opt/optbuilder.(*Builder).analyzeProjectionList

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 928 to 930 in f990441

	// aggInScope and aggOutScope.
	b.analyzeProjectionList(sel.Exprs, desiredTypes, fromScope, projectionsScope)

in pkg/sql/opt/optbuilder.(*Builder).buildSelectClause

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 866 to 868 in f990441

	case *tree.SelectClause:
	outScope = b.buildSelectClause(t, orderBy, locking, desiredTypes, inScope)

in pkg/sql/opt/optbuilder.(*Builder).buildSelectStmtWithoutParens

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 839 to 841 in f990441

	return b.processWiths(with, inScope, func(inScope *scope) *scope {
	return b.buildSelectStmtWithoutParens(
	wrapped, orderBy, limit, locking, desiredTypes, inScope,

in pkg/sql/opt/optbuilder.(*Builder).buildSelect.func1

cockroach/pkg/sql/opt/optbuilder/with.go

Lines 28 to 30 in f990441

	inScope.atRoot = false
	outScope := buildStmt(inScope)
	inScope.atRoot = prevAtRoot

in pkg/sql/opt/optbuilder.(*Builder).processWiths

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 838 to 840 in f990441

	return b.processWiths(with, inScope, func(inScope *scope) *scope {
	return b.buildSelectStmtWithoutParens(

in pkg/sql/opt/optbuilder.(*Builder).buildSelect

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 252 to 254 in f990441

	case *tree.Select:
	return b.buildSelect(stmt, noRowLocking, desiredTypes, inScope)

in pkg/sql/opt/optbuilder.(*Builder).buildStmt

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 216 to 218 in f990441

	return b.buildStmt(stmt, desiredTypes, inScope)
	}

in pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 187 to 189 in f990441

	// and physical properties.
	outScope := b.buildStmtAtRoot(b.stmt, nil /* desiredTypes */, b.allocScope())

in pkg/sql/opt/optbuilder.(*Builder).Build

cockroach/pkg/sql/plan_opt.go

Lines 432 to 434 in f990441

	bld := optbuilder.New(ctx, &p.semaCtx, p.EvalContext(), &opc.catalog, f, opc.p.stmt.AST)
	if err := bld.Build(); err != nil {
	return nil, err

in pkg/sql.(*optPlanningCtx).buildExecMemo

cockroach/pkg/sql/plan_opt.go

Lines 168 to 170 in f990441

	execMemo, err := opc.buildExecMemo(ctx)
	if err != nil {

in pkg/sql.(*planner).makeOptimizerPlan

cockroach/pkg/sql/conn_executor_exec.go

Lines 855 to 857 in f990441

	if err := planner.makeOptimizerPlan(ctx); err != nil {
	log.VEventf(ctx, 1, "optimizer plan failed: %v", err)

in pkg/sql.(*connExecutor).makeExecPlan

cockroach/pkg/sql/conn_executor_exec.go

Lines 745 to 747 in f990441

	// between here and there needs to happen even if there's an error.
	err := ex.makeExecPlan(ctx, planner)
	// We'll be closing the plan manually below after execution; this

in pkg/sql.(*connExecutor).dispatchToExecutionEngine

cockroach/pkg/sql/conn_executor_exec.go

Lines 535 to 537 in f990441

	p.autoCommit = os.ImplicitTxn.Get() && !ex.server.cfg.TestingKnobs.DisableAutoCommit
	if err := ex.dispatchToExecutionEngine(ctx, p, res); err != nil {
	return nil, nil, err

in pkg/sql.(*connExecutor).execStmtInOpenState

cockroach/pkg/sql/conn_executor_exec.go

Lines 95 to 97 in f990441

	} else {
	ev, payload, err = ex.execStmtInOpenState(ctx, stmt, res, pinfo)
	}

in pkg/sql.(*connExecutor).execStmt

cockroach/pkg/sql/conn_executor.go

Lines 1405 to 1407 in f990441

	stmtCtx := withStatement(ctx, ex.curStmt)
	ev, payload, err = ex.execStmt(stmtCtx, curStmt, stmtRes, nil /* pinfo */)
	if err != nil {

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 1334 to 1336 in f990441

	var err error
	if err = ex.execCmd(ex.Ctx()); err != nil {
	if err == io.EOF || err == errDrainingComplete {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 478 to 480 in f990441

	}()
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 581 to 583 in f990441

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn)
	}()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1
/usr/local/go/src/runtime/asm_amd64.s#L1356-L1358 in runtime.goexit

pkg/sql/sem/tree/parse_string.go in pkg/sql/sem/tree.ParseAndRequireString at line 71
pkg/sql/sem/tree/parse_array.go in pkg/sql/sem/tree.(*parseState).parseElement at line 139
pkg/sql/sem/tree/parse_array.go in pkg/sql/sem/tree.doParseDArrayFromString at line 174
pkg/sql/sem/tree/parse_array.go in pkg/sql/sem/tree.ParseDArrayFromString at line 150
pkg/sql/sem/tree/parse_string.go in pkg/sql/sem/tree.ParseAndRequireString at line 24
pkg/sql/sem/tree/constant.go in pkg/sql/sem/tree.(*StrVal).ResolveAsType at line 543
pkg/sql/sem/tree/constant.go in pkg/sql/sem/tree.typeCheckConstant at line 65
pkg/sql/sem/tree/type_check.go in pkg/sql/sem/tree.(*StrVal).TypeCheck at line 1235
pkg/sql/sem/tree/type_check.go in pkg/sql/sem/tree.(*IndirectionExpr).TypeCheck at line 503
pkg/sql/sem/tree/type_check.go in pkg/sql/sem/tree.TypeCheck at line 261
pkg/sql/opt/optbuilder/scope.go in pkg/sql/opt/optbuilder.(*scope).resolveType at line 424
pkg/sql/opt/optbuilder/project.go in pkg/sql/opt/optbuilder.(*Builder).analyzeSelectList at line 150
pkg/sql/opt/optbuilder/project.go in pkg/sql/opt/optbuilder.(*Builder).analyzeProjectionList at line 84
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelectClause at line 929
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelectStmtWithoutParens at line 867
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelect.func1 at line 840
pkg/sql/opt/optbuilder/with.go in pkg/sql/opt/optbuilder.(*Builder).processWiths at line 29
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelect at line 839
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmt at line 253
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot at line 217
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).Build at line 188
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildExecMemo at line 433
pkg/sql/plan_opt.go in pkg/sql.(*planner).makeOptimizerPlan at line 169
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).makeExecPlan at line 856
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).dispatchToExecutionEngine at line 746
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmtInOpenState at line 536
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmt at line 96
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 1406
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1335
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 479
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 582
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1357

Tag	Value
Cockroach Release	v20.1.5
Cockroach SHA:	f990441
Platform	linux amd64
Distribution	CCL
Environment	v20.1.5
Command	server
Go Version	go1.13.9
# of CPUs	2
# of Goroutines	307

[yuzefovich]

Seems related to #52134. @RaduBerinde do you think it's worth backporting #52416 to 20.1 and whether it would fix it?

[RaduBerinde]

I think it would, opened #59066.

[RaduBerinde]

Should be fixed by #59066.