release-19.2: backport avg for interval #42679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability to average intervals. Comes with a few extra tests for aggregation functions over intervals. Release note (sql change): Adds the ability to run `avg` over intervals.
Release note: none
|
This change is |
rafiss
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
lgtm
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
jordanlewis
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Why is this one in particular getting backported?
Reviewable status:
rafiss
reviewed
Nov 22, 2019
There was a problem hiding this comment.
It caused a Django test failure: cockroachdb/django-cockroachdb#72
Reviewable status:
jordanlewis
reviewed
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release