Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: fix window function for avg of intervals #42490

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

otan
Copy link
Contributor

@otan otan commented Nov 14, 2019

Resolves #42489

Release note: None

@otan otan requested review from solongordon and a team November 14, 2019 18:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: with a nit

Personally, I'd omit the release note in this case since the new code for average of intervals was merged yesterday, and there hasn't been a release since then.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan and @solongordon)


pkg/sql/logictest/testdata/logic_test/aggregate, line 609 at r1 (raw file):

00:00:00.001  7 mons 6 days 19:12:12.4002  3 years  3 years 4 days 00:01:02.001

query TT

[nit]: this query belongs to logic_test/window since avg here is used as a window function.

Copy link
Contributor Author

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @solongordon and @yuzefovich)


pkg/sql/logictest/testdata/logic_test/aggregate, line 609 at r1 (raw file):

Previously, yuzefovich wrote…

[nit]: this query belongs to logic_test/window since avg here is used as a window function.

Done.

@otan otan force-pushed the otan-int_agg_window branch from aeba953 to 8a727e1 Compare November 18, 2019 17:26
@otan
Copy link
Contributor Author

otan commented Nov 18, 2019

bors r=yuzefovich

craig bot pushed a commit that referenced this pull request Nov 18, 2019
42490: builtins: fix window function for avg of intervals r=yuzefovich a=otan

Resolves #42489

Release note: None

Co-authored-by: Oliver Tan <[email protected]>
@craig
Copy link
Contributor

craig bot commented Nov 18, 2019

Build succeeded

@craig craig bot merged commit 8a727e1 into cockroachdb:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: internal error: unexpected SUM result type
3 participants