builtins: add avg for interval #42457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
solongordon
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan and @rafiss)
pkg/sql/logictest/testdata/logic_test/aggregate, line 156 at r1 (raw file):
statement OK INSERT INTO kv VALUES (1, 2, 3, 'a', '1min'::interval),
Nit: I think the ::interval cast is unnecessary here.
This PR adds the ability to average intervals. Comes with a few extra tests for aggregation functions over intervals. Release note (sql change): Adds the ability to run `avg` over intervals.
|
ty! |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 13, 2019
42457: builtins: add avg for interval r=otan a=otan Resolves #42449 Resolves cockroachdb/django-cockroachdb#72 This PR adds the ability to average intervals. Comes with a few extra tests for aggregation functions over intervals. Release note (sql change): Adds the ability to run `avg` over intervals. Co-authored-by: Oliver Tan <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42449
Resolves cockroachdb/django-cockroachdb#72
This PR adds the ability to average intervals. Comes with a few extra
tests for aggregation functions over intervals.
Release note (sql change): Adds the ability to run
avgover intervals.