Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: roachtest: various c2c/ldr improvements #137292

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 11, 2024

Backport 3/3 commits from #137275 on behalf of @msbutler.

/cc @cockroachdb/release


commit d422abf (HEAD -> butler-pcr-gcp-only, butler/butler-pcr-gcp-only)
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:42:07 2024 -0500

roachtest: increase max accepted latency on c2c shutdown tests

The node shutdown tests occasionally fail when the latency exceeds 2 minutes;
however if the coordinator shutsdown, a new node may take up to two minutes to
adopt the job. This patch bumps the latency to 4 mintues to account for the job
system polling.

Informs #132730

Epic: none

commit cc2eb85
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:38:26 2024 -0500

roachtest: only run ldr tests on gce

We cannot debug perf based failures on other clouds as we do not collect time
series metrics on them.

Epic: none

Release note: none

commit cd89447
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:37:03 2024 -0500

roachtest: only run pcr tests on gce

We cannot debug perf based failures on other platforms without timeseries
metrics.

Epic: none

Release note: none

Release justification:

We cannot debug perf based failures on other platforms without timeseries
metrics.

Epic: none

Release note: none
We cannot debug perf based failures on other clouds as we do not collect time
series metrics on them.

Epic: none

Release note: none
The node shutdown tests occasionally fail when the latency exceeds 2 minutes;
however if the coordinator shutsdown, a new node may take up to two minutes to
adopt the job. This patch bumps the latency to 4 mintues to account for the job
system polling.

Informs #132730

Epic: none
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-137275 branch from ca94d74 to dff8f29 Compare December 11, 2024 19:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 11, 2024
@blathers-crl blathers-crl bot requested a review from jeffswenson December 11, 2024 19:02
Copy link
Author

blathers-crl bot commented Dec 11, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 11, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler msbutler merged commit a34d124 into release-24.2 Dec 13, 2024
18 of 20 checks passed
@msbutler msbutler deleted the blathers/backport-release-24.2-137275 branch December 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants