-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.2: roachtest: various c2c/ldr improvements #137292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot debug perf based failures on other platforms without timeseries metrics. Epic: none Release note: none
We cannot debug perf based failures on other clouds as we do not collect time series metrics on them. Epic: none Release note: none
The node shutdown tests occasionally fail when the latency exceeds 2 minutes; however if the coordinator shutsdown, a new node may take up to two minutes to adopt the job. This patch bumps the latency to 4 mintues to account for the job system polling. Informs #132730 Epic: none
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.2-137275
branch
from
December 11, 2024 19:02
ca94d74
to
dff8f29
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Dec 11, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Dec 11, 2024
jeffswenson
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #137275 on behalf of @msbutler.
/cc @cockroachdb/release
commit d422abf (HEAD -> butler-pcr-gcp-only, butler/butler-pcr-gcp-only)
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:42:07 2024 -0500
commit cc2eb85
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:38:26 2024 -0500
commit cd89447
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:37:03 2024 -0500
Release justification: