roachtest: various c2c/ldr improvements #137275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot debug perf based failures on other platforms without timeseries metrics. Epic: none Release note: none
We cannot debug perf based failures on other clouds as we do not collect time series metrics on them. Epic: none Release note: none
The node shutdown tests occasionally fail when the latency exceeds 2 minutes; however if the coordinator shutsdown, a new node may take up to two minutes to adopt the job. This patch bumps the latency to 4 mintues to account for the job system polling. Informs cockroachdb#132730 Epic: none
|
This change is |
|
TFTR! bors r=dt |
msbutler
added
backport-24.1.x
This was referenced Dec 11, 2024
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from cd89447 to blathers/backport-release-24.1-137275: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this pull request
Dec 17, 2024
This reduces a bunch of struct copying. For now, I'm considering the `none/parallel` benchmark diffs to be spurious. ``` ❯ benchdiff ./pkg/util/tracing -b -r 'BenchmarkTracer_StartSpanCtx' -d 100000x -c 10 test binaries already exist for 2b3e4f4: Merge cockroachdb#136225 cockroachdb#137136 cockroachdb#137216 cockroachdb#137275 cockroachdb#137281 checking out '9899e2d' building benchmark binaries for 9899e2d: tracing: pass `spanOptions` by reference [bazel=true] 1/1 \ pkg=1/1 iter=10/10 cockroachdb/cockroach/pkg/util/tracing \ name old time/op new time/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 50.0ns ± 6% 45.5ns ± 4% -8.93% (p=0.000 n=10+9) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 321ns ± 4% 301ns ± 1% -6.36% (p=0.000 n=10+8) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 343ns ± 4% 324ns ± 2% -5.60% (p=0.000 n=9+9) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 358ns ± 2% 341ns ± 2% -4.71% (p=0.000 n=10+9) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 472ns ± 2% 457ns ± 2% -3.27% (p=0.000 n=8+9) Tracer_StartSpanCtx/opts=real/parallel=false-10 292ns ± 2% 282ns ± 2% -3.15% (p=0.000 n=8+9) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 663ns ± 2% 643ns ± 4% -3.11% (p=0.002 n=9+9) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 309ns ± 2% 300ns ± 2% -3.02% (p=0.000 n=9+9) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 621ns ± 3% 608ns ± 4% -2.17% (p=0.039 n=7+9) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 826ns ± 2% 810ns ± 2% -1.95% (p=0.008 n=10+9) Tracer_StartSpanCtx/opts=real/parallel=true-10 556ns ± 5% 561ns ± 3% ~ (p=0.661 n=10+9) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 580ns ± 2% 574ns ± 2% ~ (p=0.077 n=9+9) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 635ns ± 3% 625ns ± 3% ~ (p=0.074 n=8+9) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 1.04µs ± 6% 1.03µs ± 5% ~ (p=0.735 n=10+9) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 745ns ± 1% 739ns ± 1% ~ (p=0.078 n=8+8) Tracer_StartSpanCtx/opts=none/parallel=true-10 15.3ns ±19% 22.1ns ±27% +44.39% (p=0.000 n=9+9) name old alloc/op new alloc/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=none/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 96.0B ± 0% 96.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 96.0B ± 0% 96.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 51.0B ± 0% 51.0B ± 0% ~ (all equal) name old allocs/op new allocs/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=none/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 2.00 ± 0% 2.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 2.00 ± 0% 2.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) ```
craig bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
137641: tracing: pass `spanOptions` by reference r=dhartunian a=dhartunian This reduces a bunch of struct copying. For now, I'm considering the `none/parallel` benchmark diffs to be spurious. ``` ❯ benchdiff ./pkg/util/tracing -b -r 'BenchmarkTracer_StartSpanCtx' -d 100000x -c 10 test binaries already exist for 2b3e4f4: Merge #136225 #137136 #137216 #137275 #137281 checking out '9899e2d' building benchmark binaries for 9899e2d: tracing: pass `spanOptions` by reference [bazel=true] 1/1 \ pkg=1/1 iter=10/10 cockroachdb/cockroach/pkg/util/tracing \ name old time/op new time/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 50.0ns ± 6% 45.5ns ± 4% -8.93% (p=0.000 n=10+9) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 321ns ± 4% 301ns ± 1% -6.36% (p=0.000 n=10+8) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 343ns ± 4% 324ns ± 2% -5.60% (p=0.000 n=9+9) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 358ns ± 2% 341ns ± 2% -4.71% (p=0.000 n=10+9) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 472ns ± 2% 457ns ± 2% -3.27% (p=0.000 n=8+9) Tracer_StartSpanCtx/opts=real/parallel=false-10 292ns ± 2% 282ns ± 2% -3.15% (p=0.000 n=8+9) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 663ns ± 2% 643ns ± 4% -3.11% (p=0.002 n=9+9) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 309ns ± 2% 300ns ± 2% -3.02% (p=0.000 n=9+9) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 621ns ± 3% 608ns ± 4% -2.17% (p=0.039 n=7+9) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 826ns ± 2% 810ns ± 2% -1.95% (p=0.008 n=10+9) Tracer_StartSpanCtx/opts=real/parallel=true-10 556ns ± 5% 561ns ± 3% ~ (p=0.661 n=10+9) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 580ns ± 2% 574ns ± 2% ~ (p=0.077 n=9+9) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 635ns ± 3% 625ns ± 3% ~ (p=0.074 n=8+9) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 1.04µs ± 6% 1.03µs ± 5% ~ (p=0.735 n=10+9) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 745ns ± 1% 739ns ± 1% ~ (p=0.078 n=8+8) Tracer_StartSpanCtx/opts=none/parallel=true-10 15.3ns ±19% 22.1ns ±27% +44.39% (p=0.000 n=9+9) name old alloc/op new alloc/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=none/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 96.0B ± 0% 96.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 96.0B ± 0% 96.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 51.0B ± 0% 51.0B ± 0% ~ (all equal) name old allocs/op new allocs/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=none/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 2.00 ± 0% 2.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 2.00 ± 0% 2.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) ``` Co-authored-by: David Hartunian <[email protected]>
yaothao
pushed a commit
to yaothao/cockroach
that referenced
this pull request
Dec 18, 2024
This reduces a bunch of struct copying. For now, I'm considering the `none/parallel` benchmark diffs to be spurious. ``` ❯ benchdiff ./pkg/util/tracing -b -r 'BenchmarkTracer_StartSpanCtx' -d 100000x -c 10 test binaries already exist for 2b3e4f4: Merge cockroachdb#136225 cockroachdb#137136 cockroachdb#137216 cockroachdb#137275 cockroachdb#137281 checking out '9899e2d' building benchmark binaries for 9899e2d: tracing: pass `spanOptions` by reference [bazel=true] 1/1 \ pkg=1/1 iter=10/10 cockroachdb/cockroach/pkg/util/tracing \ name old time/op new time/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 50.0ns ± 6% 45.5ns ± 4% -8.93% (p=0.000 n=10+9) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 321ns ± 4% 301ns ± 1% -6.36% (p=0.000 n=10+8) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 343ns ± 4% 324ns ± 2% -5.60% (p=0.000 n=9+9) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 358ns ± 2% 341ns ± 2% -4.71% (p=0.000 n=10+9) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 472ns ± 2% 457ns ± 2% -3.27% (p=0.000 n=8+9) Tracer_StartSpanCtx/opts=real/parallel=false-10 292ns ± 2% 282ns ± 2% -3.15% (p=0.000 n=8+9) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 663ns ± 2% 643ns ± 4% -3.11% (p=0.002 n=9+9) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 309ns ± 2% 300ns ± 2% -3.02% (p=0.000 n=9+9) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 621ns ± 3% 608ns ± 4% -2.17% (p=0.039 n=7+9) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 826ns ± 2% 810ns ± 2% -1.95% (p=0.008 n=10+9) Tracer_StartSpanCtx/opts=real/parallel=true-10 556ns ± 5% 561ns ± 3% ~ (p=0.661 n=10+9) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 580ns ± 2% 574ns ± 2% ~ (p=0.077 n=9+9) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 635ns ± 3% 625ns ± 3% ~ (p=0.074 n=8+9) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 1.04µs ± 6% 1.03µs ± 5% ~ (p=0.735 n=10+9) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 745ns ± 1% 739ns ± 1% ~ (p=0.078 n=8+8) Tracer_StartSpanCtx/opts=none/parallel=true-10 15.3ns ±19% 22.1ns ±27% +44.39% (p=0.000 n=9+9) name old alloc/op new alloc/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=none/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 96.0B ± 0% 96.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 96.0B ± 0% 96.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 48.0B ± 0% 48.0B ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 51.0B ± 0% 51.0B ± 0% ~ (all equal) name old allocs/op new allocs/op delta Tracer_StartSpanCtx/opts=none/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=none/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,logtag/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=false-10 2.00 ± 0% 2.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener/parallel=true-10 2.00 ± 0% 2.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=false-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) Tracer_StartSpanCtx/opts=real,regexp/parallel=true-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit d422abf (HEAD -> butler-pcr-gcp-only, butler/butler-pcr-gcp-only)
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:42:07 2024 -0500
commit cc2eb85
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:38:26 2024 -0500
commit cd89447
Author: Michael Butler [email protected]
Date: Wed Dec 11 10:37:03 2024 -0500