Skip to content

Commit

Permalink
roachtest: increase max accepted latency on c2c shutdown tests
Browse files Browse the repository at this point in the history
The node shutdown tests occasionally fail when the latency exceeds 2 minutes;
however if the coordinator shutsdown, a new node may take up to two minutes to
adopt the job. This patch bumps the latency to 4 mintues to account for the job
system polling.

Informs #132730

Epic: none
  • Loading branch information
msbutler committed Dec 11, 2024
1 parent 8ceb2b6 commit dff8f29
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions pkg/cmd/roachtest/tests/cluster_to_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -1590,8 +1590,12 @@ func registerClusterReplicationResilience(r registry.Registry) {
cutover: 3 * time.Minute,
expectedNodeDeaths: 1,
sometimesTestFingerprintMismatchCode: true,
clouds: registry.OnlyGCE,
suites: registry.Suites(registry.Nightly),
// The job system can take up to 2 minutes to reclaim a job if the
// coordinator dies, so increase the max expected latency to account for
// our lovely job system.
maxAcceptedLatency: 4 * time.Minute,
clouds: registry.OnlyGCE,
suites: registry.Suites(registry.Nightly),
}

c2cRegisterWrapper(r, rsp.replicationSpec,
Expand Down

0 comments on commit dff8f29

Please sign in to comment.