roachtest: fix perturbation/metamorphic/backfill #135834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this test was setting the memory spec before it called randomize. This could set it back to low memory. We already know that low memory configuration doesn't work for backfill as part of cockroachdb#133114. This change calls randomize and then sets the memory configuration. Epic: none Fixes: cockroachdb#135799 Release note: None
andrewbaptist
requested review from
DarrylWong and
vidit-bhat
and removed request for
a team
|
This change is |
kvoli
approved these changes
Nov 21, 2024
|
TFTR bors r=kvoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test was setting the memory spec before it called randomize. This could set it back to low memory. We already know that low memory configuration doesn't work for backfill as part of #133114.
This change calls randomize and then sets the memory configuration.
Epic: none
Fixes: #135799
Release note: None