Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: Index backfill can OOM on low memory configurations #133114

Open
andrewbaptist opened this issue Oct 21, 2024 · 1 comment
Open

kv: Index backfill can OOM on low memory configurations #133114

andrewbaptist opened this issue Oct 21, 2024 · 1 comment
Assignees
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-perturbation Bugs found by the perturbation framework P-3 Issues/test failures with no fix SLA T-kv KV Team

Comments

@andrewbaptist
Copy link
Collaborator

andrewbaptist commented Oct 21, 2024

Describe the problem

The perturbation/metamorphic tests can fail with an OOM on low memory configurations.

To Reproduce

Add back the low memory configuration as the first option to var memOptions.
Run the roachtest perturbation/metamorphic/backfill with the seed 8450888460406580954.

COCKROACH_RANDOM_SEED=8450888460406580954 roachtest run perturbation/metamorphic/backfill --cpu-quota 2000

Note that a node will crash with an OOM.

Expected behavior
Nodes should not crash even in low memory configurations. They should succeed and complete the task slower.

Jira issue: CRDB-43460

@andrewbaptist andrewbaptist added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Oct 21, 2024
Copy link

blathers-crl bot commented Oct 21, 2024

Hi @andrewbaptist, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@andrewbaptist andrewbaptist added P-3 Issues/test failures with no fix SLA branch-master Failures and bugs on the master branch. T-kv KV Team labels Oct 21, 2024
andrewbaptist added a commit to andrewbaptist/cockroach that referenced this issue Oct 21, 2024
Previously the perturbation/* roachtests were configured with low memory
configurations. This resulted in OOMs for backfill tests. This change
makes the memory configuration a metamorphic parameter but excludes low
memory configurations. The perturbation/full tests are run with standard
memory.

Informs: cockroachdb#133114
Fixes: cockroachdb#133086
Fixes: cockroachdb#131713
Epic: none

Release note: None
craig bot pushed a commit that referenced this issue Oct 21, 2024
133115: roachtest: change to use standard memory configuration r=arulajmani a=andrewbaptist

Previously the perturbation/* roachtests were configured with low memory configurations. This resulted in OOMs for backfill tests. This change makes the memory configuration a metamorphic parameter but excludes low memory configurations. The perturbation/full tests are run with standard memory.

Informs: #133114
Fixes: #133086
Fixes: #131713
Epic: none

Release note: None

Co-authored-by: Andrew Baptist <[email protected]>
blathers-crl bot pushed a commit that referenced this issue Oct 28, 2024
Previously the perturbation/* roachtests were configured with low memory
configurations. This resulted in OOMs for backfill tests. This change
makes the memory configuration a metamorphic parameter but excludes low
memory configurations. The perturbation/full tests are run with standard
memory.

Informs: #133114
Fixes: #133086
Fixes: #131713
Epic: none

Release note: None
andrewbaptist added a commit to andrewbaptist/cockroach that referenced this issue Nov 20, 2024
Previously this test was setting the memory spec before it called
randomize. This could set it back to low memory. We already know that
low memory configuration doesn't work for backfill as part of cockroachdb#133114.

This change calls randomize and then sets the memory configuration.

Epic: none
Fixes: cockroachdb#135799

Release note: None
craig bot pushed a commit that referenced this issue Nov 21, 2024
135834: roachtest: fix perturbation/metamorphic/backfill r=kvoli a=andrewbaptist

Previously this test was setting the memory spec before it called randomize. This could set it back to low memory. We already know that low memory configuration doesn't work for backfill as part of #133114.

This change calls randomize and then sets the memory configuration.

Epic: none
Fixes: #135799

Release note: None

Co-authored-by: Andrew Baptist <[email protected]>
@andrewbaptist andrewbaptist added the O-perturbation Bugs found by the perturbation framework label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-perturbation Bugs found by the perturbation framework P-3 Issues/test failures with no fix SLA T-kv KV Team
Projects
None yet
Development

No branches or pull requests

1 participant