Skip to content

Commit

Permalink
Merge #135834
Browse files Browse the repository at this point in the history
135834: roachtest: fix perturbation/metamorphic/backfill r=kvoli a=andrewbaptist

Previously this test was setting the memory spec before it called randomize. This could set it back to low memory. We already know that low memory configuration doesn't work for backfill as part of #133114.

This change calls randomize and then sets the memory configuration.

Epic: none
Fixes: #135799

Release note: None

Co-authored-by: Andrew Baptist <[email protected]>
  • Loading branch information
craig[bot] and andrewbaptist committed Nov 21, 2024
2 parents 5c3cfd9 + a3ed94c commit 6af5017
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/cmd/roachtest/tests/perturbation/index_backfill.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ func (b backfill) setupMetamorphic(rng *rand.Rand) variations {
v := b.setup()
// TODO(#133114): The backfill test can cause OOM with low memory
// configurations.
v = v.randomize(rng)
if v.mem == spec.Low {
v.mem = spec.Standard
}
return v.randomize(rng)
return v
}

// startTargetNode starts the target node and creates the backfill table.
Expand Down

0 comments on commit 6af5017

Please sign in to comment.