Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: bazel: never strip output binaries #128234

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bazel: never strip output binaries
To date, binaries are stripped by default when building with Bazel. We
skip stripping for release binaries (via `-c opt`) and if you're
building with the `dev` configuration (many developers use this
configuration as `dev doctor` guides you to). This has led to some
confusion as these mechanisms are non-obvious, leading some to wonder
why their binaries are (or are not) stripped. We simplify this by
*never* stripping. Since release binaries are not stripped, they are
unaffected by this change. Only developers building without the `dev`
config and CI jobs that don't set `-c opt` would be affected.

Epic: CRDB-17171

Release note: None
rickystewart committed Aug 1, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 26568cfab7956abc052eabe2224a1c621312b149
2 changes: 1 addition & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@ build --define gotags=bazel,gss
build --experimental_proto_descriptor_sets_include_source_info
build --incompatible_strict_action_env --incompatible_enable_cc_toolchain_resolution
build --symlink_prefix=_bazel/
build:dev --strip=never
build --strip=never
common --experimental_allow_tags_propagation
test --config=test --experimental_ui_max_stdouterr_bytes=10485760
build --ui_event_filters=-DEBUG