Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: bazel: never strip output binaries #128234

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 2, 2024

Backport 1/1 commits from #128128 on behalf of @rickystewart.

/cc @cockroachdb/release


To date, binaries are stripped by default when building with Bazel. We skip stripping for release binaries (via -c opt) and if you're building with the dev configuration (many developers use this configuration as dev doctor guides you to). This has led to some confusion as these mechanisms are non-obvious, leading some to wonder why their binaries are (or are not) stripped. We simplify this by never stripping. Since release binaries are not stripped, they are unaffected by this change. Only developers building without the dev config and CI jobs that don't set -c opt would be affected.

Epic: CRDB-17171

Release note: None


Release justification: Non-production code changes

To date, binaries are stripped by default when building with Bazel. We
skip stripping for release binaries (via `-c opt`) and if you're
building with the `dev` configuration (many developers use this
configuration as `dev doctor` guides you to). This has led to some
confusion as these mechanisms are non-obvious, leading some to wonder
why their binaries are (or are not) stripped. We simplify this by
*never* stripping. Since release binaries are not stripped, they are
unaffected by this change. Only developers building without the `dev`
config and CI jobs that don't set `-c opt` would be affected.

Epic: CRDB-17171

Release note: None
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 2, 2024
Copy link
Author

blathers-crl bot commented Aug 2, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from rail August 2, 2024 21:57
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 2, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart merged commit b6311c7 into release-24.2 Aug 5, 2024
19 of 20 checks passed
@rickystewart rickystewart deleted the blathers/backport-release-24.2-128128 branch August 5, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants